From: Mark Brown <broonie@kernel.org>
To: Li Xiubo <Li.Xiubo@freescale.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"timur@tabi.org" <timur@tabi.org>,
"perex@perex.cz" <perex@perex.cz>,
Huan Wang <Huan.Wang@freescale.com>,
"LW@KARO-electronics.de" <LW@KARO-electronics.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Shawn Guo <Shawn.Guo@freescale.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Zhengxiong Jin <Jason.Jin@freescale.com>,
oskar
Subject: Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.
Date: Thu, 7 Nov 2013 20:38:38 +0000 [thread overview]
Message-ID: <20131107203838.GC2493@sirena.org.uk> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F828783E6@039-SN2MPN1-013.039d.mgd.msft.net>
[-- Attachment #1.1: Type: text/plain, Size: 908 bytes --]
On Thu, Nov 07, 2013 at 03:01:02AM +0000, Li Xiubo wrote:
> > > The SGTL5000 is based on regulators and when it is disabled, there
> > > will be an error returns directly while the SGTL5000 codec is probing.
> > What makes you say this?
> static int ldo_regulator_register(struct snd_soc_codec *codec,
> struct regulator_init_data *init_data,
> int voltage)
If the regulator is not used in the system then why is the driver
getting as far as trying to register it? Surely this is a system
configuration error? This all sounds like some problem with either the
system integration or the driver which is causing it to try to register
the regulator needlessly - you should be fixing that problem, not adding
ifdefs. I'm still unclear on exactly what the issue is so it's hard to
say exactly what the best way forwards is.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Li Xiubo <Li.Xiubo@freescale.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"timur@tabi.org" <timur@tabi.org>,
"perex@perex.cz" <perex@perex.cz>,
Huan Wang <Huan.Wang@freescale.com>,
"LW@KARO-electronics.de" <LW@KARO-electronics.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Shawn Guo <Shawn.Guo@freescale.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Zhengxiong Jin <Jason.Jin@freescale.com>,
"oskar@scara.com" <oskar@scara.com>,
Fabio Estevam <Fabio.Estevam@freescale.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob@landley.net" <rob@landley.net>,
Guangyu Chen <guangyu.chen@freescale.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.
Date: Thu, 7 Nov 2013 20:38:38 +0000 [thread overview]
Message-ID: <20131107203838.GC2493@sirena.org.uk> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F828783E6@039-SN2MPN1-013.039d.mgd.msft.net>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Thu, Nov 07, 2013 at 03:01:02AM +0000, Li Xiubo wrote:
> > > The SGTL5000 is based on regulators and when it is disabled, there
> > > will be an error returns directly while the SGTL5000 codec is probing.
> > What makes you say this?
> static int ldo_regulator_register(struct snd_soc_codec *codec,
> struct regulator_init_data *init_data,
> int voltage)
If the regulator is not used in the system then why is the driver
getting as far as trying to register it? Surely this is a system
configuration error? This all sounds like some problem with either the
system integration or the driver which is causing it to try to register
the regulator needlessly - you should be fixing that problem, not adding
ifdefs. I'm still unclear on exactly what the issue is so it's hard to
say exactly what the best way forwards is.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.
Date: Thu, 7 Nov 2013 20:38:38 +0000 [thread overview]
Message-ID: <20131107203838.GC2493@sirena.org.uk> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F828783E6@039-SN2MPN1-013.039d.mgd.msft.net>
On Thu, Nov 07, 2013 at 03:01:02AM +0000, Li Xiubo wrote:
> > > The SGTL5000 is based on regulators and when it is disabled, there
> > > will be an error returns directly while the SGTL5000 codec is probing.
> > What makes you say this?
> static int ldo_regulator_register(struct snd_soc_codec *codec,
> struct regulator_init_data *init_data,
> int voltage)
If the regulator is not used in the system then why is the driver
getting as far as trying to register it? Surely this is a system
configuration error? This all sounds like some problem with either the
system integration or the driver which is causing it to try to register
the regulator needlessly - you should be fixing that problem, not adding
ifdefs. I'm still unclear on exactly what the issue is so it's hard to
say exactly what the best way forwards is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131107/fd5aef54/attachment-0001.sig>
next prev parent reply other threads:[~2013-11-07 20:38 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 7:04 (unknown), Xiubo Li
2013-11-01 7:04 ` No subject Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
[not found] ` <1383289495-24523-2-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-11-01 8:59 ` Nicolin Chen
2013-11-01 8:59 ` Nicolin Chen
2013-11-01 8:59 ` Nicolin Chen
2013-11-04 3:45 ` Li Xiubo
2013-11-04 3:45 ` Li Xiubo
2013-11-04 3:45 ` Li Xiubo
2013-11-04 4:33 ` Nicolin Chen
2013-11-04 4:33 ` Nicolin Chen
2013-11-04 4:33 ` Nicolin Chen
2013-11-20 3:37 ` Li Xiubo
2013-11-20 3:37 ` Li Xiubo
2013-11-20 3:37 ` Li Xiubo
2013-11-20 3:37 ` Nicolin Chen
2013-11-20 3:37 ` Nicolin Chen
2013-11-20 3:37 ` Nicolin Chen
2013-11-20 4:16 ` Li Xiubo
2013-11-20 4:16 ` Li Xiubo
2013-11-20 4:16 ` Li Xiubo
2013-11-05 13:26 ` Timur Tabi
2013-11-05 13:26 ` Timur Tabi
2013-11-05 13:26 ` Timur Tabi
2013-11-06 3:27 ` Li Xiubo
2013-11-06 3:27 ` Li Xiubo
2013-11-06 3:27 ` Li Xiubo
2013-11-06 3:31 ` Timur Tabi
2013-11-06 3:31 ` Timur Tabi
2013-11-06 3:31 ` Timur Tabi
2013-11-06 3:53 ` Li Xiubo
2013-11-06 3:53 ` Li Xiubo
2013-11-06 3:53 ` Li Xiubo
2013-11-06 8:12 ` Shawn Guo
2013-11-06 8:12 ` Shawn Guo
2013-11-06 8:12 ` Shawn Guo
2013-11-06 9:38 ` Li Xiubo
2013-11-06 9:38 ` Li Xiubo
2013-11-06 9:38 ` Li Xiubo
2013-11-01 18:25 ` Mark Brown
2013-11-01 18:25 ` Mark Brown
2013-11-01 18:25 ` Mark Brown
2013-11-04 7:35 ` Li Xiubo
2013-11-04 7:35 ` Li Xiubo
2013-11-04 7:35 ` Li Xiubo
2013-11-04 16:15 ` Mark Brown
2013-11-04 16:15 ` Mark Brown
2013-11-04 16:15 ` Mark Brown
2013-11-05 3:21 ` Li Xiubo
2013-11-05 3:21 ` Li Xiubo
2013-11-05 3:21 ` Li Xiubo
2013-11-06 9:53 ` Mark Brown
2013-11-06 9:53 ` Mark Brown
2013-11-06 9:53 ` Mark Brown
2013-11-01 7:04 ` [PATCHv2 2/8] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` [PATCHv2 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-18 18:07 ` Bill Pringlemeir
2013-11-20 3:14 ` Li Xiubo
2013-11-20 16:04 ` Bill Pringlemeir
2013-11-20 16:04 ` Bill Pringlemeir
2013-11-21 2:58 ` Li Xiubo
2013-11-21 2:58 ` Li Xiubo
2013-11-21 14:55 ` Bill Pringlemeir
2013-11-21 14:55 ` Bill Pringlemeir
2013-11-22 6:46 ` Li Xiubo
2013-11-22 6:46 ` Li Xiubo
2013-11-22 15:09 ` Bill Pringlemeir
2013-11-22 15:09 ` Bill Pringlemeir
2013-11-28 7:45 ` Li Xiubo
2013-11-28 7:45 ` Li Xiubo
2013-11-01 7:04 ` [PATCHv2 4/8] Documentation: Add device tree bindings for Freescale SAI Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
[not found] ` <1383289495-24523-6-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-11-01 10:02 ` Nicolin Chen
2013-11-01 10:02 ` Nicolin Chen
2013-11-01 10:02 ` Nicolin Chen
2013-11-01 18:50 ` Mark Brown
2013-11-01 18:50 ` Mark Brown
2013-11-01 18:50 ` Mark Brown
2013-11-06 8:59 ` Li Xiubo
2013-11-06 8:59 ` Li Xiubo
2013-11-06 8:59 ` Li Xiubo
2013-11-06 10:03 ` Mark Brown
2013-11-06 10:03 ` Mark Brown
2013-11-06 10:03 ` Mark Brown
2013-11-07 3:01 ` Li Xiubo
2013-11-07 3:01 ` Li Xiubo
2013-11-07 3:01 ` Li Xiubo
2013-11-07 20:38 ` Mark Brown [this message]
2013-11-07 20:38 ` Mark Brown
2013-11-07 20:38 ` Mark Brown
2013-11-01 7:04 ` [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 10:17 ` Oskar Schirmer
2013-11-01 10:17 ` Oskar Schirmer
2013-11-05 3:26 ` Li Xiubo
2013-11-05 3:26 ` Li Xiubo
2013-11-05 3:26 ` Li Xiubo
2013-11-01 10:28 ` Nicolin Chen
2013-11-01 10:28 ` Nicolin Chen
2013-11-01 10:28 ` Nicolin Chen
2013-11-01 12:07 ` Shawn Guo
2013-11-01 12:07 ` Shawn Guo
2013-11-01 12:07 ` Shawn Guo
2013-11-05 6:17 ` Li Xiubo
2013-11-05 6:17 ` Li Xiubo
2013-11-05 6:17 ` Li Xiubo
2013-11-05 3:50 ` Li Xiubo
2013-11-05 3:50 ` Li Xiubo
2013-11-05 3:50 ` Li Xiubo
2013-11-01 18:40 ` Mark Brown
2013-11-01 18:40 ` Mark Brown
2013-11-01 18:40 ` Mark Brown
2013-11-04 9:52 ` Li Xiubo
2013-11-04 9:52 ` Li Xiubo
2013-11-04 9:52 ` Li Xiubo
2013-11-20 7:49 ` Li Xiubo
2013-11-20 7:49 ` Li Xiubo
2013-11-20 7:49 ` Li Xiubo
2013-11-01 7:04 ` [PATCHv2 7/8] ARM: dts: Enable SGTL5000 codec based audio driver node for VF610 Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` [PATCHv2 8/8] Documentation: Add device tree bindings for Freescale VF610 sound Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:04 ` Xiubo Li
2013-11-01 7:52 ` [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Li Xiubo
2013-11-01 7:52 ` Li Xiubo
2013-11-01 7:52 ` Li Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107203838.GC2493@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Huan.Wang@freescale.com \
--cc=Jason.Jin@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=Li.Xiubo@freescale.com \
--cc=Shawn.Guo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.