All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: dm Kconfig: fix menu indentation
Date: Thu, 7 Nov 2013 22:54:39 -0500	[thread overview]
Message-ID: <20131108035438.GA9290@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1311071204230.10583@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Nov 07 2013 at 12:05pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> The option DM_LOG_USERSPACE is sub-option of DM_MIRROR, so it should be
> placed right after DM_MIRROR.
> 
> If we place DM_LOG_USERSPACE after DM_MIRROR, the config menu is correctly
> indented:
> <M>   Device mapper support
> [ ]     Device mapper debugging support
> <M>     Crypt target support
> <M>     Snapshot target
> <M>     Thin provisioning target
> [ ]       Keep stack trace of thin provisioning block lock holders
> <M>     Cache target (EXPERIMENTAL)
> <M>       MQ Cache Policy (EXPERIMENTAL)
> <M>       Cleaner Cache Policy (EXPERIMENTAL)
> <M>     Mirror target
> < >       Mirror userspace logging
> <M>     RAID 1/4/5/6/10 target
> <M>     Zero target
> <M>     Multipath target
> <M>       I/O Path Selector based on the number of in-flight I/Os
> <M>       I/O Path Selector based on the service time
> <M>     I/O delaying target
> [*]     DM uevents
> <M>     Flakey target
> <M>     Verity target support
> <M>     Switch target support (EXPERIMENTAL)
> 
> Previously, the menu was indented incorrectly:
> <M>   Device mapper support
> [ ]     Device mapper debugging support
> <M>     Crypt target support
> <M>     Snapshot target
> <M>     Thin provisioning target
> [ ]       Keep stack trace of thin provisioning block lock holders
> <M>     Cache target (EXPERIMENTAL)
> <M>       MQ Cache Policy (EXPERIMENTAL)
> <M>       Cleaner Cache Policy (EXPERIMENTAL)
> <M>     Mirror target
> <M>     RAID 1/4/5/6/10 target
> < >   Mirror userspace logging
> <M>   Zero target
> <M>   Multipath target
> <M>     I/O Path Selector based on the number of in-flight I/Os
> <M>     I/O Path Selector based on the service time
> <M>   I/O delaying target
> [*]   DM uevents
> <M>   Flakey target
> <M>   Verity target support
> <M>   Switch target support (EXPERIMENTAL)
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Great, I've wondered by the indentation was wrong.  Thanks for fixing
this.

      reply	other threads:[~2013-11-08  3:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 17:05 [PATCH] dm Kconfig: fix menu indentation Mikulas Patocka
2013-11-08  3:54 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108035438.GA9290@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.