[PATCH] dm Kconfig: fix menu indentation

[PATCH] dm Kconfig: fix menu indentation

[Mikulas Patocka]

The option DM_LOG_USERSPACE is sub-option of DM_MIRROR, so it should be
placed right after DM_MIRROR.

If we place DM_LOG_USERSPACE after DM_MIRROR, the config menu is correctly
indented:
<M>   Device mapper support
[ ]     Device mapper debugging support
<M>     Crypt target support
<M>     Snapshot target
<M>     Thin provisioning target
[ ]       Keep stack trace of thin provisioning block lock holders
<M>     Cache target (EXPERIMENTAL)
<M>       MQ Cache Policy (EXPERIMENTAL)
<M>       Cleaner Cache Policy (EXPERIMENTAL)
<M>     Mirror target
< >       Mirror userspace logging
<M>     RAID 1/4/5/6/10 target
<M>     Zero target
<M>     Multipath target
<M>       I/O Path Selector based on the number of in-flight I/Os
<M>       I/O Path Selector based on the service time
<M>     I/O delaying target
[*]     DM uevents
<M>     Flakey target
<M>     Verity target support
<M>     Switch target support (EXPERIMENTAL)

Previously, the menu was indented incorrectly:
<M>   Device mapper support
[ ]     Device mapper debugging support
<M>     Crypt target support
<M>     Snapshot target
<M>     Thin provisioning target
[ ]       Keep stack trace of thin provisioning block lock holders
<M>     Cache target (EXPERIMENTAL)
<M>       MQ Cache Policy (EXPERIMENTAL)
<M>       Cleaner Cache Policy (EXPERIMENTAL)
<M>     Mirror target
<M>     RAID 1/4/5/6/10 target
< >   Mirror userspace logging
<M>   Zero target
<M>   Multipath target
<M>     I/O Path Selector based on the number of in-flight I/Os
<M>     I/O Path Selector based on the service time
<M>   I/O delaying target
[*]   DM uevents
<M>   Flakey target
<M>   Verity target support
<M>   Switch target support (EXPERIMENTAL)

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

---
 drivers/md/Kconfig |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

Index: linux-2.6-test/drivers/md/Kconfig
===================================================================
--- linux-2.6-test.orig/drivers/md/Kconfig	2013-11-07 17:57:38.000000000 +0100
+++ linux-2.6-test/drivers/md/Kconfig	2013-11-07 17:57:53.000000000 +0100
@@ -297,6 +297,17 @@ config DM_MIRROR
          Allow volume managers to mirror logical volumes, also
          needed for live data migration tools such as 'pvmove'.
 
+config DM_LOG_USERSPACE
+	tristate "Mirror userspace logging"
+	depends on DM_MIRROR && NET
+	select CONNECTOR
+	---help---
+	  The userspace logging module provides a mechanism for
+	  relaying the dm-dirty-log API to userspace.  Log designs
+	  which are more suited to userspace implementation (e.g.
+	  shared storage logs) or experimental logs can be implemented
+	  by leveraging this framework.
+
 config DM_RAID
        tristate "RAID 1/4/5/6/10 target"
        depends on BLK_DEV_DM
@@ -323,17 +334,6 @@ config DM_RAID
 	 RAID-5, RAID-6 distributes the syndromes across the drives
 	 in one of the available parity distribution methods.
 
-config DM_LOG_USERSPACE
-	tristate "Mirror userspace logging"
-	depends on DM_MIRROR && NET
-	select CONNECTOR
-	---help---
-	  The userspace logging module provides a mechanism for
-	  relaying the dm-dirty-log API to userspace.  Log designs
-	  which are more suited to userspace implementation (e.g.
-	  shared storage logs) or experimental logs can be implemented
-	  by leveraging this framework.
-
 config DM_ZERO
 	tristate "Zero target"
 	depends on BLK_DEV_DM

Re: dm Kconfig: fix menu indentation

[Mike Snitzer]

On Thu, Nov 07 2013 at 12:05pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> The option DM_LOG_USERSPACE is sub-option of DM_MIRROR, so it should be
> placed right after DM_MIRROR.
> 
> If we place DM_LOG_USERSPACE after DM_MIRROR, the config menu is correctly
> indented:
> <M>   Device mapper support
> [ ]     Device mapper debugging support
> <M>     Crypt target support
> <M>     Snapshot target
> <M>     Thin provisioning target
> [ ]       Keep stack trace of thin provisioning block lock holders
> <M>     Cache target (EXPERIMENTAL)
> <M>       MQ Cache Policy (EXPERIMENTAL)
> <M>       Cleaner Cache Policy (EXPERIMENTAL)
> <M>     Mirror target
> < >       Mirror userspace logging
> <M>     RAID 1/4/5/6/10 target
> <M>     Zero target
> <M>     Multipath target
> <M>       I/O Path Selector based on the number of in-flight I/Os
> <M>       I/O Path Selector based on the service time
> <M>     I/O delaying target
> [*]     DM uevents
> <M>     Flakey target
> <M>     Verity target support
> <M>     Switch target support (EXPERIMENTAL)
> 
> Previously, the menu was indented incorrectly:
> <M>   Device mapper support
> [ ]     Device mapper debugging support
> <M>     Crypt target support
> <M>     Snapshot target
> <M>     Thin provisioning target
> [ ]       Keep stack trace of thin provisioning block lock holders
> <M>     Cache target (EXPERIMENTAL)
> <M>       MQ Cache Policy (EXPERIMENTAL)
> <M>       Cleaner Cache Policy (EXPERIMENTAL)
> <M>     Mirror target
> <M>     RAID 1/4/5/6/10 target
> < >   Mirror userspace logging
> <M>   Zero target
> <M>   Multipath target
> <M>     I/O Path Selector based on the number of in-flight I/Os
> <M>     I/O Path Selector based on the service time
> <M>   I/O delaying target
> [*]   DM uevents
> <M>   Flakey target
> <M>   Verity target support
> <M>   Switch target support (EXPERIMENTAL)
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Great, I've wondered by the indentation was wrong.  Thanks for fixing
this.