From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Karel Zak <kzak@redhat.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Wanglin \(Albert\)" <albert.wanglin@hisilicon.com>
Subject: Re: [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib
Date: Fri, 8 Nov 2013 06:13:47 -0300 [thread overview]
Message-ID: <20131108091216.GA2365@localhost> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F1C08B274@szxeml512-mbs.china.huawei.com>
On Fri, Nov 08, 2013 at 06:53:29AM +0000, Caizhiyong wrote:
> >> For further information, see "https://lkml.org/lkml/2013/8/6/550"
> >
> > Thanks for doing this. Could we please get some acked-by's or,
> > preferably, tested-by's from the MTD people?
>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
I don't remember acking this patch! Instead, I do remember asking
for the test results, prooving the this change has _no_ change of
behavior compared to the MTD parsing code:
https://lkml.org/lkml/2013/10/25/164
Such results was never posted and unless we see those, I think
I'd rather NACK this patch instead. I like the cleanup, but only
if it's guaranteed to _not_ brake things, specially when dealing
with a kernel parameter.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Brian Norris <computersforpeace@gmail.com>,
"Wanglin (Albert)" <albert.wanglin@hisilicon.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Karel Zak <kzak@redhat.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: Re: [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib
Date: Fri, 8 Nov 2013 06:13:47 -0300 [thread overview]
Message-ID: <20131108091216.GA2365@localhost> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F1C08B274@szxeml512-mbs.china.huawei.com>
On Fri, Nov 08, 2013 at 06:53:29AM +0000, Caizhiyong wrote:
> >> For further information, see "https://lkml.org/lkml/2013/8/6/550"
> >
> > Thanks for doing this. Could we please get some acked-by's or,
> > preferably, tested-by's from the MTD people?
>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
I don't remember acking this patch! Instead, I do remember asking
for the test results, prooving the this change has _no_ change of
behavior compared to the MTD parsing code:
https://lkml.org/lkml/2013/10/25/164
Such results was never posted and unless we see those, I think
I'd rather NACK this patch instead. I like the cleanup, but only
if it's guaranteed to _not_ brake things, specially when dealing
with a kernel parameter.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-08 9:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 11:19 [PATCH] mtd: cmdlinepart: use cmdline partition parser lib Caizhiyong
2013-08-15 11:19 ` Caizhiyong
2013-10-20 12:06 ` Ezequiel Garcia
2013-10-20 12:06 ` Ezequiel Garcia
2013-10-22 13:12 ` [PATCH 1/2] block: remove unrelated header files and export symbol Caizhiyong
2013-10-22 13:12 ` Caizhiyong
2013-10-22 13:14 ` [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib Caizhiyong
2013-10-22 13:14 ` Caizhiyong
2013-11-05 22:43 ` Andrew Morton
2013-11-05 22:43 ` Andrew Morton
2013-11-05 23:47 ` Brian Norris
2013-11-05 23:47 ` Brian Norris
2013-11-08 7:13 ` Caizhiyong
2013-11-08 7:13 ` Caizhiyong
2013-11-08 6:53 ` Caizhiyong
2013-11-08 6:53 ` Caizhiyong
2013-11-08 9:13 ` Ezequiel Garcia [this message]
2013-11-08 9:13 ` Ezequiel Garcia
2013-11-08 9:58 ` Caizhiyong
2013-11-08 9:58 ` Caizhiyong
2013-10-25 11:52 ` [PATCH] " Caizhiyong
2013-10-25 11:52 ` Caizhiyong
2013-10-25 12:09 ` Ezequiel Garcia
2013-10-25 12:09 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108091216.GA2365@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=albert.wanglin@hisilicon.com \
--cc=caizhiyong@hisilicon.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.