All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: agraf@suse.de, ehabkost@redhat.com, peter.maydell@linaro.org,
	jan.kiszka@siemens.com, qemu-devel@nongnu.org,
	lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com,
	lersek@redhat.com, afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches
Date: Sun, 10 Nov 2013 14:47:46 +0200	[thread overview]
Message-ID: <20131110124746.GA7602@redhat.com> (raw)
In-Reply-To: <1384085725-23522-1-git-send-email-marcel.a@redhat.com>

On Sun, Nov 10, 2013 at 02:15:23PM +0200, Marcel Apfelbaum wrote:
> The master-abort patch introduced a background memory region
> covering all 64 bit pci address space, the visible parts
> being the unused pci-holes addresses.
> 
> The patch revealed the following issues:
>  1. Some memory regions have INT64_MAX size, but the size
>     was supposed to be UINT64_MAX (meaning that the
>     region covers all 64 bit address space). Having
>     a region that is not even a multiple of PAGE_SIZE
>     is really not what we want.
>  2. exec.c does not support all the 64 bit address range
>     and when using an unsupported address, it leads to
>     page tables corruption.
>  3. Some memory regions overlap and the visible region
>     is selected by chance (the algorithm implementation)
>     and not by the memory API:
>     - selecting a proper priority
>     - arrange the regions that are not supposed to overlap.
>     
> This series reverts this patch and another related patch
> because the impact for 1.7 is too big.
> After the issues above are solved, the patch can finally
> be applied.

I edited the commit log slightly and applied this, thanks.

> Marcel Apfelbaum (1):
>   Revert "hw/pci: partially handle pci master abort"
> 
> Michael S. Tsirkin (1):
>   Revert "exec: limit system memory size"
> 
>  exec.c                   |  7 +------
>  hw/pci/pci.c             | 26 --------------------------
>  include/hw/pci/pci_bus.h |  1 -
>  3 files changed, 1 insertion(+), 33 deletions(-)
> 
> -- 
> 1.8.3.1

      parent reply	other threads:[~2013-11-10 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10 12:15 [Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches Marcel Apfelbaum
2013-11-10 12:15 ` [Qemu-devel] [PATCH for-1.7 1/2] Revert "hw/pci: partially handle pci master abort" Marcel Apfelbaum
2013-11-10 12:15 ` [Qemu-devel] [PATCH for-1.7 2/2] Revert "exec: limit system memory size" Marcel Apfelbaum
2013-11-10 12:47 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131110124746.GA7602@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@amazon.com \
    --cc=ehabkost@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=lcapitulino@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.