From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area
Date: Mon, 11 Nov 2013 12:45:55 +0530 [thread overview]
Message-ID: <20131111071555.GB2559@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131109190344.GA32281@redhat.com>
* Oleg Nesterov <oleg@redhat.com> [2013-11-09 20:03:44]:
> 1. Don't include asm/uprobes.h unconditionally, we only need
> it if CONFIG_UPROBES.
>
> 2. Move the definition of "struct xol_area" into uprobes.c.
>
> Perhaps we should simply kill struct uprobes_state, it buys
> nothing.
>
> 3. Kill the dummy definition of uprobe_get_swbp_addr(), nobody
> except handle_swbp() needs it.
>
> 4. Purely cosmetic, but move the decl of uprobe_get_swbp_addr()
> up, close to other __weak helpers.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
next prev parent reply other threads:[~2013-11-11 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 19:03 [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area Oleg Nesterov
2013-11-11 7:15 ` Srikar Dronamraju [this message]
2013-11-11 8:41 ` Ingo Molnar
2013-11-11 19:58 ` Oleg Nesterov
2013-11-11 21:03 ` Ingo Molnar
2013-11-19 16:25 ` [PATCH] uprobes: Document xol_area and arch_uprobe->insn/ixol Oleg Nesterov
2013-11-19 19:24 ` Ingo Molnar
2013-11-20 11:03 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111071555.GB2559@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.