* [Buildroot] [PATCH] libqmi: fix autobuild failures
@ 2013-11-11 15:43 spdawson at gmail.com
2013-11-11 15:47 ` Baruch Siach
2013-11-11 16:24 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: spdawson at gmail.com @ 2013-11-11 15:43 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
The libqmi build specifies -Werror in the CFLAGS by default. This causes
build failures such as the following.
http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/
The -Werror flag can be disabled using a configuration switch.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
package/libqmi/libqmi.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
index 911b1a7..8bd4577 100644
--- a/package/libqmi/libqmi.mk
+++ b/package/libqmi/libqmi.mk
@@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
LIBQMI_DEPENDENCIES = libglib2
+LIBQMI_CONF_OPT = --enable-more-warnings=yes
+
$(eval $(autotools-package))
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] libqmi: fix autobuild failures
2013-11-11 15:43 [Buildroot] [PATCH] libqmi: fix autobuild failures spdawson at gmail.com
@ 2013-11-11 15:47 ` Baruch Siach
2013-11-11 16:24 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2013-11-11 15:47 UTC (permalink / raw)
To: buildroot
Hi Simon,
On Mon, Nov 11, 2013 at 03:43:47PM +0000, spdawson at gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> The libqmi build specifies -Werror in the CFLAGS by default. This causes
> build failures such as the following.
>
> http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/
>
> The -Werror flag can be disabled using a configuration switch.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> package/libqmi/libqmi.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
> index 911b1a7..8bd4577 100644
> --- a/package/libqmi/libqmi.mk
> +++ b/package/libqmi/libqmi.mk
> @@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
>
> LIBQMI_DEPENDENCIES = libglib2
>
> +LIBQMI_CONF_OPT = --enable-more-warnings=yes
A comment would be nice. Something like:
# Disable -Werror
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] libqmi: fix autobuild failures
2013-11-11 15:43 [Buildroot] [PATCH] libqmi: fix autobuild failures spdawson at gmail.com
2013-11-11 15:47 ` Baruch Siach
@ 2013-11-11 16:24 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-11-11 16:24 UTC (permalink / raw)
To: buildroot
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
> From: Simon Dawson <spdawson@gmail.com>
> The libqmi build specifies -Werror in the CFLAGS by default. This causes
> build failures such as the following.
> http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/
> The -Werror flag can be disabled using a configuration switch.
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> package/libqmi/libqmi.mk | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
> index 911b1a7..8bd4577 100644
> --- a/package/libqmi/libqmi.mk
> +++ b/package/libqmi/libqmi.mk
> @@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
> LIBQMI_DEPENDENCIES = libglib2
> +LIBQMI_CONF_OPT = --enable-more-warnings=yes
That's not immediately obvious. Looking at compiler-warnings.m4 I see
that =yes adds a bunch of -Wblah options to CFLAGS, so I instead changed
it to =no and added a comment why.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-11 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 15:43 [Buildroot] [PATCH] libqmi: fix autobuild failures spdawson at gmail.com
2013-11-11 15:47 ` Baruch Siach
2013-11-11 16:24 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.