Re: [meta-fsl-arm-extra][PATCH 2/3] wandboard.inc: add

["Eric Bénard" <eric@eukrea.com>]

Hi Otavio,

Le Tue, 12 Nov 2013 10:07:11 -0200,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Tue, Nov 12, 2013 at 10:05 AM, Eric Bénard <eric@eukrea.com> wrote:
> > Hi Otavio,
> >
> > Le Tue, 12 Nov 2013 09:54:16 -0200,
> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> >> It does not have the wifi module but it can be used (and is commonly
> >> seen doing it) a usb dongle for it. So I think it is good to have the
> >> wifi support in.
> >>
> > with this argument you can also keep bluetooth (or anything else which
> > can be hotplug) as this also _can_ be plugged into an USB port ;-)
> 
> What you'd expect? Do you prefer to drop it?
> 
> I am fine with both ways.
> 
I think MACHINE_FEATURES must represent what the machine really have
and not what it can have (IMHO, defining if an image must support wifi
if the machine doesn't have it by default is more a DISTRO policy or an
image level choice).

in the wifi case I think this doesn't prevent wifi tools to be
installed as packagegroup-base has :
    ${@base_contains('COMBINED_FEATURES', 'wifi',
    'packagegroup-base-wifi', '',d)} \
-> wifi not installed in packagegroup-base if not present in both
MACHINE & DISTRO features.

but packagegroup-base also have :
packagegroup-base-extended :
    if "wifi" in distro_features and not "wifi" in machine_features and
("pcmcia" in machine_features or "pci" in machine_features or "usbhost"
in machine_features): d.setVar("ADD_WIFI", "packagegroup-base-wifi")

So as we have usbhost (and pci) packagegroup-base-extended will get
wifi tools even if MACHINE_FEATURES doesn't have it.

in core-image.bbclass we have :
CORE_IMAGE_BASE_INSTALL = '\
    packagegroup-core-boot \
    packagegroup-base-extended \
..."

so if I'm not wrong, even if MACHINE_FEATURES doesn't have wifi we will
get wifi tools in the image if DISTRO_FEATURES contains wifi.

Eric