From: Mario Domenech Goulart <mario@ossystems.com.br>
To: Daiane Angolini <daiane.list@gmail.com>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm-extra][PATCH 2/3] wandboard.inc: add
Date: Tue, 12 Nov 2013 11:32:15 +0000 [thread overview]
Message-ID: <87li0t7t4w.fsf@parenteses.org> (raw)
In-Reply-To: <CA+jg_OVWf+GcYtObJpzVhHUqp86pPRB5FAS1srJP+_8zXLHCqg@mail.gmail.com> (Daiane Angolini's message of "Tue, 12 Nov 2013 09:21:26 -0200")
Hi Daiane,
On Tue, 12 Nov 2013 09:21:26 -0200 Daiane Angolini <daiane.list@gmail.com> wrote:
> On Mon, Nov 11, 2013 at 2:44 PM, Mario Domenech Goulart <mario@ossystems.com.br> wrote:
>> Common settings for wandboard-quad, wandboard-dual and wandboard-solo.
>
> What?
>
> I like you patch, but I think you can improve this commit log/subject.
I'm gonna submit the patches again, since I created them against dora by
mistake. While at it, I'll improve the commit message.
Best wishes.
Mario
>
>
> Daiane
>
>>
>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>> ---
>> conf/machine/include/wandboard.inc | 10 ++++++++++
>> conf/machine/wandboard-dual.conf | 9 ++-------
>> conf/machine/wandboard-quad.conf | 9 ++-------
>> conf/machine/wandboard-solo.conf | 9 +--------
>> 4 files changed, 15 insertions(+), 22 deletions(-)
>> create mode 100644 conf/machine/include/wandboard.inc
>>
>> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
>> new file mode 100644
>> index 0000000..a304b11
>> --- /dev/null
>> +++ b/conf/machine/include/wandboard.inc
>> @@ -0,0 +1,10 @@
>> +# Common settings for wandboard boards
>> +
>> +include conf/machine/include/imx-base.inc
>> +include conf/machine/include/tune-cortexa9.inc
>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
>> +
>> +SERIAL_CONSOLE = "115200 ttymxc0"
>> +
>> +MACHINE_FEATURES += "pci wifi"
>> diff --git a/conf/machine/wandboard-dual.conf b/conf/machine/wandboard-dual.conf
>> index eaee17b..1821192 100644
>> --- a/conf/machine/wandboard-dual.conf
>> +++ b/conf/machine/wandboard-dual.conf
>> @@ -3,19 +3,14 @@
>> #@SOC: i.MX6DL
>> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Duallite
>>
>> -include conf/machine/include/imx-base.inc
>> -include conf/machine/include/tune-cortexa9.inc
>> +include include/wandboard.inc
>>
>> SOC_FAMILY = "mx6:mx6dl:wandboard"
>>
>> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
>> -
>> UBOOT_MACHINE = "wandboard_dl_config"
>>
>> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb"
>>
>> -SERIAL_CONSOLE = "115200 ttymxc0"
>> -
>> -MACHINE_FEATURES += " pci wifi bluetooth"
>> +MACHINE_FEATURES += "bluetooth"
>>
>> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config"
>> diff --git a/conf/machine/wandboard-quad.conf b/conf/machine/wandboard-quad.conf
>> index 4f32590..195a69f 100644
>> --- a/conf/machine/wandboard-quad.conf
>> +++ b/conf/machine/wandboard-quad.conf
>> @@ -3,19 +3,14 @@
>> #@SOC: i.MX6Q
>> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Quad
>>
>> -include conf/machine/include/imx-base.inc
>> -include conf/machine/include/tune-cortexa9.inc
>> +include include/wandboard.inc
>>
>> SOC_FAMILY = "mx6:mx6q:wandboard"
>>
>> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
>> -
>> UBOOT_MACHINE = "wandboard_quad_config"
>>
>> KERNEL_DEVICETREE = "imx6q-wandboard.dtb"
>>
>> -SERIAL_CONSOLE = "115200 ttymxc0"
>> -
>> -MACHINE_FEATURES += " pci wifi bluetooth"
>> +MACHINE_FEATURES += "bluetooth"
>>
>> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config"
>> diff --git a/conf/machine/wandboard-solo.conf b/conf/machine/wandboard-solo.conf
>> index 970e650..9696aeb 100644
>> --- a/conf/machine/wandboard-solo.conf
>> +++ b/conf/machine/wandboard-solo.conf
>> @@ -3,17 +3,10 @@
>> #@SOC: i.MX6S
>> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo
>>
>> -include conf/machine/include/imx-base.inc
>> -include conf/machine/include/tune-cortexa9.inc
>> +include include/wandboard.inc
>>
>> SOC_FAMILY = "mx6:mx6s:wandboard"
>>
>> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
>> -
>> UBOOT_MACHINE = "wandboard_solo_config"
>>
>> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb"
>> -
>> -SERIAL_CONSOLE = "115200 ttymxc0"
>> -
>> -MACHINE_FEATURES += " pci wifi"
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>
next prev parent reply other threads:[~2013-11-12 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 16:44 [meta-fsl-arm-extra][PATCH 1/3] linux-wandboard_3.0.35: update to d35902c7 Mario Domenech Goulart
2013-11-11 16:44 ` [meta-fsl-arm-extra][PATCH 2/3] wandboard.inc: add Mario Domenech Goulart
2013-11-12 11:21 ` Daiane Angolini
2013-11-12 11:32 ` Mario Domenech Goulart [this message]
2013-11-12 11:51 ` Eric Bénard
2013-11-12 11:54 ` Otavio Salvador
2013-11-12 12:05 ` Eric Bénard
2013-11-12 12:07 ` Otavio Salvador
2013-11-12 13:21 ` Eric Bénard
2013-11-12 11:56 ` Fabio Estevam
2013-11-12 11:59 ` Otavio Salvador
2013-11-12 12:03 ` Fabio Estevam
2013-11-12 13:23 ` Eric Bénard
2013-11-12 14:06 ` Fabio Estevam
2013-11-12 14:14 ` Eric Bénard
2013-11-12 14:22 ` Otavio Salvador
2013-11-11 16:44 ` [meta-fsl-arm-extra][PATCH 3/3] wandboard.inc: add touchscreen support Mario Domenech Goulart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li0t7t4w.fsf@parenteses.org \
--to=mario@ossystems.com.br \
--cc=daiane.list@gmail.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.