From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Bryan Benson <bmbenson-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] ixgbe: Fix offloading bits when RX bulk alloc is used.
Date: Tue, 12 Nov 2013 18:21:52 +0100 [thread overview]
Message-ID: <201311121821.53077.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <52824E21.20405-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
12/11/2013 16:49, Ivan Boule :
> On 11/08/2013 08:47 PM, Bryan Benson wrote:
> > This is a fix for the ixgbe hardware offload flags not being set when
> > bulk alloc RX is used. The issue was caused by masking off the bits that
> > store the hardware offload values in the status_error field to retrieve
> > the done bit for the descriptor.
> >
> > Commit 7431041062b9fd0555bac7ca4abebc99e3379fa5 in DPDK-1.3.0 introduced
> > bulk dequeue, which included the bug. ---
> >
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
>
> Acked.
Applied.
Good catch. Thanks
--
Thomas
prev parent reply other threads:[~2013-11-12 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 19:47 [PATCH] ixgbe: Fix offloading bits when RX bulk alloc is used Bryan Benson
[not found] ` <1383940042-31770-1-git-send-email-bmbenson-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2013-11-12 15:49 ` Ivan Boule
[not found] ` <52824E21.20405-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-11-12 17:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311121821.53077.thomas.monjalon@6wind.com \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=bmbenson-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.