* [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error [not found] <1384274383-43510-1-git-send-email-trenn@suse.de> @ 2013-11-12 21:58 ` tip-bot for Thomas Renninger 2013-11-12 22:45 ` Borislav Petkov 0 siblings, 1 reply; 11+ messages in thread From: tip-bot for Thomas Renninger @ 2013-11-12 21:58 UTC (permalink / raw) To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, stable, trenn, tglx, bp Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa Author: Thomas Renninger <trenn@suse.de> AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error Do it the same way as done in microcode_intel.c: use pr_debug() for missing firmware files. There seem to be CPUs out there for which no microcode update has been submitted to kernel-firmware repo yet resulting in scary sounding error messages in dmesg: microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin Signed-off-by: Thomas Renninger <trenn@suse.de> Acked-by: Borislav Petkov <bp@suse.de> Cc: <stable@kernel.org> Link: http://lkml.kernel.org/r/1384274383-43510-1-git-send-email-trenn@suse.de Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/kernel/microcode_amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c index af99f71..c3d4cc9 100644 --- a/arch/x86/kernel/microcode_amd.c +++ b/arch/x86/kernel/microcode_amd.c @@ -431,7 +431,7 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device, snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86); if (request_firmware(&fw, (const char *)fw_name, device)) { - pr_err("failed to load file %s\n", fw_name); + pr_debug("failed to load file %s\n", fw_name); goto out; } ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 21:58 ` [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error tip-bot for Thomas Renninger @ 2013-11-12 22:45 ` Borislav Petkov 2013-11-12 23:00 ` Ingo Molnar 2013-11-12 23:01 ` Borislav Petkov 0 siblings, 2 replies; 11+ messages in thread From: Borislav Petkov @ 2013-11-12 22:45 UTC (permalink / raw) To: mingo, hpa, linux-kernel, stable, tglx, trenn, bp; +Cc: linux-tip-commits On Tue, Nov 12, 2013 at 01:58:00PM -0800, tip-bot for Thomas Renninger wrote: > Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa > Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa > Author: Thomas Renninger <trenn@suse.de> > AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 > Committer: Ingo Molnar <mingo@kernel.org> > CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 > > x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error > > Do it the same way as done in microcode_intel.c: use pr_debug() > for missing firmware files. > > There seem to be CPUs out there for which no microcode update > has been submitted to kernel-firmware repo yet resulting in > scary sounding error messages in dmesg: > > microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin > > Signed-off-by: Thomas Renninger <trenn@suse.de> > Acked-by: Borislav Petkov <bp@suse.de> > Cc: <stable@kernel.org> Shouldn't that be <stable@vger.kernel.org> ? -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 22:45 ` Borislav Petkov @ 2013-11-12 23:00 ` Ingo Molnar 2013-11-13 2:12 ` H. Peter Anvin 2013-11-12 23:01 ` Borislav Petkov 1 sibling, 1 reply; 11+ messages in thread From: Ingo Molnar @ 2013-11-12 23:00 UTC (permalink / raw) To: Borislav Petkov; +Cc: hpa, linux-kernel, stable, tglx, trenn, linux-tip-commits * Borislav Petkov <bp@suse.de> wrote: > On Tue, Nov 12, 2013 at 01:58:00PM -0800, tip-bot for Thomas Renninger wrote: > > Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa > > Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa > > Author: Thomas Renninger <trenn@suse.de> > > AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 > > Committer: Ingo Molnar <mingo@kernel.org> > > CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 > > > > x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error > > > > Do it the same way as done in microcode_intel.c: use pr_debug() > > for missing firmware files. > > > > There seem to be CPUs out there for which no microcode update > > has been submitted to kernel-firmware repo yet resulting in > > scary sounding error messages in dmesg: > > > > microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin > > > > Signed-off-by: Thomas Renninger <trenn@suse.de> > > Acked-by: Borislav Petkov <bp@suse.de> > > Cc: <stable@kernel.org> > > Shouldn't that be <stable@vger.kernel.org> ? Indeed that is the documented alias, although stable@kernel.org works as well and is used frequently: comet:~/tip> git log v3.0..v3.12 | grep 'stable@kernel.org' | wc -l 1390 comet:~/tip> git log v3.0..v3.12 | grep 'stable@vger.kernel.org' | wc -l 4750 Thanks, Ingo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 23:00 ` Ingo Molnar @ 2013-11-13 2:12 ` H. Peter Anvin 2013-11-13 3:08 ` Ingo Molnar 0 siblings, 1 reply; 11+ messages in thread From: H. Peter Anvin @ 2013-11-13 2:12 UTC (permalink / raw) To: Ingo Molnar, Borislav Petkov Cc: linux-kernel, stable, tglx, trenn, linux-tip-commits On 11/12/2013 03:00 PM, Ingo Molnar wrote: > > Indeed that is the documented alias, although stable@kernel.org works as > well and is used frequently: > No, it doesn't; it has bounced for the past two years. -hpa ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-13 2:12 ` H. Peter Anvin @ 2013-11-13 3:08 ` Ingo Molnar 0 siblings, 0 replies; 11+ messages in thread From: Ingo Molnar @ 2013-11-13 3:08 UTC (permalink / raw) To: H. Peter Anvin Cc: Borislav Petkov, linux-kernel, stable, tglx, trenn, linux-tip-commits * H. Peter Anvin <hpa@zytor.com> wrote: > On 11/12/2013 03:00 PM, Ingo Molnar wrote: > > > > Indeed that is the documented alias, although stable@kernel.org works > > as well and is used frequently: > > > > No, it doesn't; it has bounced for the past two years. 'works' as in the patches get picked up into -stable by Greg. :-) Thanks, Ingo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 22:45 ` Borislav Petkov 2013-11-12 23:00 ` Ingo Molnar @ 2013-11-12 23:01 ` Borislav Petkov 2013-11-12 23:10 ` Ingo Molnar 1 sibling, 1 reply; 11+ messages in thread From: Borislav Petkov @ 2013-11-12 23:01 UTC (permalink / raw) To: mingo, hpa, linux-kernel, stable, tglx, trenn, linux-tip-commits (fixed stable@vger). On Tue, Nov 12, 2013 at 11:45:11PM +0100, Borislav Petkov wrote: > On Tue, Nov 12, 2013 at 01:58:00PM -0800, tip-bot for Thomas Renninger wrote: > > Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa > > Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa > > Author: Thomas Renninger <trenn@suse.de> > > AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 > > Committer: Ingo Molnar <mingo@kernel.org> > > CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 > > > > x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error > > > > Do it the same way as done in microcode_intel.c: use pr_debug() > > for missing firmware files. > > > > There seem to be CPUs out there for which no microcode update > > has been submitted to kernel-firmware repo yet resulting in > > scary sounding error messages in dmesg: > > > > microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin > > > > Signed-off-by: Thomas Renninger <trenn@suse.de> > > Acked-by: Borislav Petkov <bp@suse.de> > > Cc: <stable@kernel.org> > > Shouldn't that be <stable@vger.kernel.org> ? Yes, it should: Final-Recipient: rfc822; stable@kernel.org Action: failed Status: 5.0.0 Diagnostic-Code: X-Postfix; host mail.kernel.org[198.145.19.201] said: 550 5.1.1 <stable@kernel.org>: Recipient address rejected: User unknown in local recipient table (in reply to RCPT TO command) -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 23:01 ` Borislav Petkov @ 2013-11-12 23:10 ` Ingo Molnar 2013-11-12 23:19 ` Borislav Petkov ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Ingo Molnar @ 2013-11-12 23:10 UTC (permalink / raw) To: Borislav Petkov, Greg Kroah-Hartman Cc: hpa, linux-kernel, stable, tglx, trenn, linux-tip-commits * Borislav Petkov <bp@suse.de> wrote: > (fixed stable@vger). > > On Tue, Nov 12, 2013 at 11:45:11PM +0100, Borislav Petkov wrote: > > On Tue, Nov 12, 2013 at 01:58:00PM -0800, tip-bot for Thomas Renninger wrote: > > > Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa > > > Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa > > > Author: Thomas Renninger <trenn@suse.de> > > > AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 > > > Committer: Ingo Molnar <mingo@kernel.org> > > > CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 > > > > > > x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error > > > > > > Do it the same way as done in microcode_intel.c: use pr_debug() > > > for missing firmware files. > > > > > > There seem to be CPUs out there for which no microcode update > > > has been submitted to kernel-firmware repo yet resulting in > > > scary sounding error messages in dmesg: > > > > > > microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin > > > > > > Signed-off-by: Thomas Renninger <trenn@suse.de> > > > Acked-by: Borislav Petkov <bp@suse.de> > > > Cc: <stable@kernel.org> > > > > Shouldn't that be <stable@vger.kernel.org> ? > > Yes, it should: > > Final-Recipient: rfc822; stable@kernel.org > Action: failed > Status: 5.0.0 > Diagnostic-Code: X-Postfix; host mail.kernel.org[198.145.19.201] said: 550 > 5.1.1 <stable@kernel.org>: Recipient address rejected: User unknown in > local recipient table (in reply to RCPT TO command) Hm, that's really weird, I've been using <stable@kernel.org> for years and the commits do get picked up. I also never saw such a mailer failure. In any case I've changed my pre-cooked alias to <stable@vger.kernel.org>, but still I'm wondering why <stable@kernel.org> seems to be working in practice - maybe Greg is picking up such commits as well, not via an email flow but via scripting? Thanks, Ingo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 23:10 ` Ingo Molnar @ 2013-11-12 23:19 ` Borislav Petkov 2013-11-13 1:09 ` Thomas Renninger 2013-11-13 2:11 ` Greg Kroah-Hartman 2 siblings, 0 replies; 11+ messages in thread From: Borislav Petkov @ 2013-11-12 23:19 UTC (permalink / raw) To: Ingo Molnar Cc: Greg Kroah-Hartman, hpa, linux-kernel, stable, tglx, trenn, linux-tip-commits On Wed, Nov 13, 2013 at 12:10:08AM +0100, Ingo Molnar wrote: > Hm, that's really weird, I've been using <stable@kernel.org> for years > and the commits do get picked up. I also never saw such a mailer > failure. > > In any case I've changed my pre-cooked alias to > <stable@vger.kernel.org>, but still I'm wondering why > <stable@kernel.org> seems to be working in practice - maybe Greg > is picking up such commits as well, not via an email flow but via > scripting? I believe I read somewhere him saying that he does. But the stable@kernel.org thing as an email address doesn't work. I'd guess he greps commit messages for "stable@" or so... -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 23:10 ` Ingo Molnar 2013-11-12 23:19 ` Borislav Petkov @ 2013-11-13 1:09 ` Thomas Renninger 2013-11-13 1:39 ` Ingo Molnar 2013-11-13 2:11 ` Greg Kroah-Hartman 2 siblings, 1 reply; 11+ messages in thread From: Thomas Renninger @ 2013-11-13 1:09 UTC (permalink / raw) To: Ingo Molnar Cc: Borislav Petkov, Greg Kroah-Hartman, hpa, linux-kernel, stable, tglx, linux-tip-commits On Wednesday, November 13, 2013 12:10:08 AM Ingo Molnar wrote: > * Borislav Petkov <bp@suse.de> wrote: ... > > > Shouldn't that be <stable@vger.kernel.org> ? > > > > Yes, it should: > > > > Final-Recipient: rfc822; stable@kernel.org > > Action: failed > > Status: 5.0.0 > > Diagnostic-Code: X-Postfix; host mail.kernel.org[198.145.19.201] said: 550 > > > > 5.1.1 <stable@kernel.org>: Recipient address rejected: User unknown in > > local recipient table (in reply to RCPT TO command) > > Hm, that's really weird, I've been using <stable@kernel.org> for years and > the commits do get picked up. I also never saw such a mailer failure. Argh, I used stable@vger.kernel.org for quite some time already. I copied the wrong one in a rush. > In any case I've changed my pre-cooked alias to <stable@vger.kernel.org>, > but still I'm wondering why <stable@kernel.org> seems to be working in > practice - maybe Greg is picking up such commits as well, not via an email > flow but via scripting? Do I have to resubmit? Thanks for picking this one up that quickly, Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-13 1:09 ` Thomas Renninger @ 2013-11-13 1:39 ` Ingo Molnar 0 siblings, 0 replies; 11+ messages in thread From: Ingo Molnar @ 2013-11-13 1:39 UTC (permalink / raw) To: Thomas Renninger Cc: Borislav Petkov, Greg Kroah-Hartman, hpa, linux-kernel, stable, tglx, linux-tip-commits * Thomas Renninger <trenn@suse.de> wrote: > On Wednesday, November 13, 2013 12:10:08 AM Ingo Molnar wrote: > > * Borislav Petkov <bp@suse.de> wrote: > ... > > > > Shouldn't that be <stable@vger.kernel.org> ? > > > > > > Yes, it should: > > > > > > Final-Recipient: rfc822; stable@kernel.org > > > Action: failed > > > Status: 5.0.0 > > > Diagnostic-Code: X-Postfix; host mail.kernel.org[198.145.19.201] said: 550 > > > > > > 5.1.1 <stable@kernel.org>: Recipient address rejected: User unknown in > > > local recipient table (in reply to RCPT TO command) > > > > Hm, that's really weird, I've been using <stable@kernel.org> for years and > > the commits do get picked up. I also never saw such a mailer failure. > Argh, I used stable@vger.kernel.org for quite some time already. > I copied the wrong one in a rush. > > > In any case I've changed my pre-cooked alias to <stable@vger.kernel.org>, > > but still I'm wondering why <stable@kernel.org> seems to be working in > > practice - maybe Greg is picking up such commits as well, not via an email > > flow but via scripting? > Do I have to resubmit? No need, it's fine. Thanks, Ingo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error 2013-11-12 23:10 ` Ingo Molnar 2013-11-12 23:19 ` Borislav Petkov 2013-11-13 1:09 ` Thomas Renninger @ 2013-11-13 2:11 ` Greg Kroah-Hartman 2 siblings, 0 replies; 11+ messages in thread From: Greg Kroah-Hartman @ 2013-11-13 2:11 UTC (permalink / raw) To: Ingo Molnar Cc: Borislav Petkov, hpa, linux-kernel, stable, tglx, trenn, linux-tip-commits On Wed, Nov 13, 2013 at 12:10:08AM +0100, Ingo Molnar wrote: > > * Borislav Petkov <bp@suse.de> wrote: > > > (fixed stable@vger). > > > > On Tue, Nov 12, 2013 at 11:45:11PM +0100, Borislav Petkov wrote: > > > On Tue, Nov 12, 2013 at 01:58:00PM -0800, tip-bot for Thomas Renninger wrote: > > > > Commit-ID: 11f918d3e2d3861b6931e97b3aa778e4984935aa > > > > Gitweb: http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa > > > > Author: Thomas Renninger <trenn@suse.de> > > > > AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100 > > > > Committer: Ingo Molnar <mingo@kernel.org> > > > > CommitDate: Tue, 12 Nov 2013 22:03:49 +0100 > > > > > > > > x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error > > > > > > > > Do it the same way as done in microcode_intel.c: use pr_debug() > > > > for missing firmware files. > > > > > > > > There seem to be CPUs out there for which no microcode update > > > > has been submitted to kernel-firmware repo yet resulting in > > > > scary sounding error messages in dmesg: > > > > > > > > microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin > > > > > > > > Signed-off-by: Thomas Renninger <trenn@suse.de> > > > > Acked-by: Borislav Petkov <bp@suse.de> > > > > Cc: <stable@kernel.org> > > > > > > Shouldn't that be <stable@vger.kernel.org> ? > > > > Yes, it should: > > > > Final-Recipient: rfc822; stable@kernel.org > > Action: failed > > Status: 5.0.0 > > Diagnostic-Code: X-Postfix; host mail.kernel.org[198.145.19.201] said: 550 > > 5.1.1 <stable@kernel.org>: Recipient address rejected: User unknown in > > local recipient table (in reply to RCPT TO command) > > Hm, that's really weird, I've been using <stable@kernel.org> for years and > the commits do get picked up. I also never saw such a mailer failure. > > In any case I've changed my pre-cooked alias to <stable@vger.kernel.org>, > but still I'm wondering why <stable@kernel.org> seems to be working in > practice - maybe Greg is picking up such commits as well, not via an email > flow but via scripting? Yes, my scripts pick up both, as this is a very common mistake (the address did change after kernel.org got rebuilt, so you were right in remembering this as the original address to use.) So no worries, I can handle both. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-11-13 3:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1384274383-43510-1-git-send-email-trenn@suse.de>
2013-11-12 21:58 ` [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error tip-bot for Thomas Renninger
2013-11-12 22:45 ` Borislav Petkov
2013-11-12 23:00 ` Ingo Molnar
2013-11-13 2:12 ` H. Peter Anvin
2013-11-13 3:08 ` Ingo Molnar
2013-11-12 23:01 ` Borislav Petkov
2013-11-12 23:10 ` Ingo Molnar
2013-11-12 23:19 ` Borislav Petkov
2013-11-13 1:09 ` Thomas Renninger
2013-11-13 1:39 ` Ingo Molnar
2013-11-13 2:11 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.