* [PATCH] perf trace: Tweak summary output
@ 2013-11-13 12:21 Pekka Enberg
2013-11-13 12:57 ` Ingo Molnar
2013-11-15 7:24 ` [tip:perf/urgent] " tip-bot for Pekka Enberg
0 siblings, 2 replies; 5+ messages in thread
From: Pekka Enberg @ 2013-11-13 12:21 UTC (permalink / raw)
To: linux-kernel
Cc: Pekka Enberg, David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo
Tweak the summary output as suggested by Ingo Molnar:
[penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1
^C
Summary of events:
Xorg (817), 148 events, 0.0%, 0.000 msec
syscall calls min avg max stddev
(msec) (msec) (msec) (%)
--------------- -------- --------- --------- --------- ------
read 7 0.002 0.004 0.011 32.00%
rt_sigprocmask 40 0.001 0.001 0.002 1.31%
ioctl 6 0.002 0.003 0.005 19.45%
writev 7 0.004 0.018 0.059 43.76%
select 9 0.000 74.513 507.869 74.61%
setitimer 4 0.001 0.002 0.002 10.08%
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
tools/perf/builtin-trace.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 2a6149e..943087f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2104,9 +2104,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
printed += fprintf(fp, "\n");
- printed += fprintf(fp, " msec/call\n");
- printed += fprintf(fp, " syscall calls min avg max stddev\n");
- printed += fprintf(fp, " --------------- -------- -------- -------- -------- ------\n");
+ printed += fprintf(fp, " syscall calls min avg max stddev\n");
+ printed += fprintf(fp, " (msec) (msec) (msec) (%%)\n");
+ printed += fprintf(fp, " --------------- -------- --------- --------- --------- ------\n");
/* each int_node is a syscall */
while (inode) {
@@ -2123,9 +2123,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
sc = &trace->syscalls.table[inode->i];
printed += fprintf(fp, " %-15s", sc->name);
- printed += fprintf(fp, " %8" PRIu64 " %8.3f %8.3f",
+ printed += fprintf(fp, " %8" PRIu64 " %9.3f %9.3f",
n, min, avg);
- printed += fprintf(fp, " %8.3f %6.2f\n", max, pct);
+ printed += fprintf(fp, " %9.3f %9.2f%%\n", max, pct);
}
inode = intlist__next(inode);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf trace: Tweak summary output
2013-11-13 12:21 [PATCH] perf trace: Tweak summary output Pekka Enberg
@ 2013-11-13 12:57 ` Ingo Molnar
2013-11-13 13:25 ` Pekka Enberg
2013-11-15 7:24 ` [tip:perf/urgent] " tip-bot for Pekka Enberg
1 sibling, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2013-11-13 12:57 UTC (permalink / raw)
To: Pekka Enberg
Cc: linux-kernel, David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo
* Pekka Enberg <penberg@kernel.org> wrote:
> Tweak the summary output as suggested by Ingo Molnar:
>
> [penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1
> ^C
> Summary of events:
>
> Xorg (817), 148 events, 0.0%, 0.000 msec
>
> syscall calls min avg max stddev
> (msec) (msec) (msec) (%)
> --------------- -------- --------- --------- --------- ------
> read 7 0.002 0.004 0.011 32.00%
> rt_sigprocmask 40 0.001 0.001 0.002 1.31%
> ioctl 6 0.002 0.003 0.005 19.45%
> writev 7 0.004 0.018 0.059 43.76%
> select 9 0.000 74.513 507.869 74.61%
> setitimer 4 0.001 0.002 0.002 10.08%
Acked-by: Ingo Molnar <mingo@kernel.org>
Are you convinced about double-digit precision output for percentages?
I think it suggest a false level of accuracy, but YYMV - typographically
xx.yy certainly looks nicer than xx.y (it's more symmetric).
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf trace: Tweak summary output
2013-11-13 12:57 ` Ingo Molnar
@ 2013-11-13 13:25 ` Pekka Enberg
2013-11-13 13:31 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Pekka Enberg @ 2013-11-13 13:25 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML, David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo
On Wed, Nov 13, 2013 at 2:57 PM, Ingo Molnar <mingo@kernel.org> wrote:
> Are you convinced about double-digit precision output for percentages?
>
> I think it suggest a false level of accuracy, but YYMV - typographically
> xx.yy certainly looks nicer than xx.y (it's more symmetric).
Yeah, I think it's OK.
Pekka
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf trace: Tweak summary output
2013-11-13 13:25 ` Pekka Enberg
@ 2013-11-13 13:31 ` Ingo Molnar
0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2013-11-13 13:31 UTC (permalink / raw)
To: Pekka Enberg; +Cc: LKML, David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo
* Pekka Enberg <penberg@kernel.org> wrote:
> On Wed, Nov 13, 2013 at 2:57 PM, Ingo Molnar <mingo@kernel.org> wrote:
> > Are you convinced about double-digit precision output for percentages?
> >
> > I think it suggest a false level of accuracy, but YYMV - typographically
> > xx.yy certainly looks nicer than xx.y (it's more symmetric).
>
> Yeah, I think it's OK.
ok.
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/urgent] perf trace: Tweak summary output
2013-11-13 12:21 [PATCH] perf trace: Tweak summary output Pekka Enberg
2013-11-13 12:57 ` Ingo Molnar
@ 2013-11-15 7:24 ` tip-bot for Pekka Enberg
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Pekka Enberg @ 2013-11-15 7:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, mingo, hpa, mingo, penberg, dsahern, tglx
Commit-ID: 27a778b512e002d856952b4f01842ba4d34bc3d1
Gitweb: http://git.kernel.org/tip/27a778b512e002d856952b4f01842ba4d34bc3d1
Author: Pekka Enberg <penberg@kernel.org>
AuthorDate: Wed, 13 Nov 2013 14:21:48 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 14 Nov 2013 15:59:20 -0300
perf trace: Tweak summary output
Tweak the summary output as suggested by Ingo Molnar:
[penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1
^C
Summary of events:
Xorg (817), 148 events, 0.0%, 0.000 msec
syscall calls min avg max stddev
(msec) (msec) (msec) (%)
--------------- -------- --------- --------- --------- ------
read 7 0.002 0.004 0.011 32.00%
rt_sigprocmask 40 0.001 0.001 0.002 1.31%
ioctl 6 0.002 0.003 0.005 19.45%
writev 7 0.004 0.018 0.059 43.76%
select 9 0.000 74.513 507.869 74.61%
setitimer 4 0.001 0.002 0.002 10.08%
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Link: http://lkml.kernel.org/r/1384345308-24404-1-git-send-email-penberg@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 6b230af..8be17fc 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2112,9 +2112,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
printed += fprintf(fp, "\n");
- printed += fprintf(fp, " msec/call\n");
- printed += fprintf(fp, " syscall calls min avg max stddev\n");
- printed += fprintf(fp, " --------------- -------- -------- -------- -------- ------\n");
+ printed += fprintf(fp, " syscall calls min avg max stddev\n");
+ printed += fprintf(fp, " (msec) (msec) (msec) (%%)\n");
+ printed += fprintf(fp, " --------------- -------- --------- --------- --------- ------\n");
/* each int_node is a syscall */
while (inode) {
@@ -2131,9 +2131,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
sc = &trace->syscalls.table[inode->i];
printed += fprintf(fp, " %-15s", sc->name);
- printed += fprintf(fp, " %8" PRIu64 " %8.3f %8.3f",
+ printed += fprintf(fp, " %8" PRIu64 " %9.3f %9.3f",
n, min, avg);
- printed += fprintf(fp, " %8.3f %6.2f\n", max, pct);
+ printed += fprintf(fp, " %9.3f %9.2f%%\n", max, pct);
}
inode = intlist__next(inode);
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-15 7:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-13 12:21 [PATCH] perf trace: Tweak summary output Pekka Enberg
2013-11-13 12:57 ` Ingo Molnar
2013-11-13 13:25 ` Pekka Enberg
2013-11-13 13:31 ` Ingo Molnar
2013-11-15 7:24 ` [tip:perf/urgent] " tip-bot for Pekka Enberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.