All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com
Subject: Re: [PATCH] x86/early quirk: use gen6 stolen detection for VLV
Date: Wed, 13 Nov 2013 21:22:59 +0200	[thread overview]
Message-ID: <20131113192259.GI7819@intel.com> (raw)
In-Reply-To: <1384280259-800-1-git-send-email-jbarnes@virtuousgeek.org>

On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> We've always been able to use either method on VLV, but it appears more
> recent BIOSes only support the gen6 method, so switch over to that.

I'm not sure what tha means since we've been using the gen6 method for
a long time now (except for the early quirk).

But anyways this matches the specs so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=71370
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  arch/x86/kernel/early-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 96f958d..bc4a088 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -330,8 +330,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
>  	INTEL_I915GM_IDS(gen3_stolen_size),
>  	INTEL_I945G_IDS(gen3_stolen_size),
>  	INTEL_I945GM_IDS(gen3_stolen_size),
> -	INTEL_VLV_M_IDS(gen3_stolen_size),
> -	INTEL_VLV_D_IDS(gen3_stolen_size),
> +	INTEL_VLV_M_IDS(gen6_stolen_size),
> +	INTEL_VLV_D_IDS(gen6_stolen_size),
>  	INTEL_PINEVIEW_IDS(gen3_stolen_size),
>  	INTEL_I965G_IDS(gen3_stolen_size),
>  	INTEL_G33_IDS(gen3_stolen_size),
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com
Subject: Re: [Intel-gfx] [PATCH] x86/early quirk: use gen6 stolen detection for VLV
Date: Wed, 13 Nov 2013 21:22:59 +0200	[thread overview]
Message-ID: <20131113192259.GI7819@intel.com> (raw)
In-Reply-To: <1384280259-800-1-git-send-email-jbarnes@virtuousgeek.org>

On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> We've always been able to use either method on VLV, but it appears more
> recent BIOSes only support the gen6 method, so switch over to that.

I'm not sure what tha means since we've been using the gen6 method for
a long time now (except for the early quirk).

But anyways this matches the specs so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=71370
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  arch/x86/kernel/early-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 96f958d..bc4a088 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -330,8 +330,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
>  	INTEL_I915GM_IDS(gen3_stolen_size),
>  	INTEL_I945G_IDS(gen3_stolen_size),
>  	INTEL_I945GM_IDS(gen3_stolen_size),
> -	INTEL_VLV_M_IDS(gen3_stolen_size),
> -	INTEL_VLV_D_IDS(gen3_stolen_size),
> +	INTEL_VLV_M_IDS(gen6_stolen_size),
> +	INTEL_VLV_D_IDS(gen6_stolen_size),
>  	INTEL_PINEVIEW_IDS(gen3_stolen_size),
>  	INTEL_I965G_IDS(gen3_stolen_size),
>  	INTEL_G33_IDS(gen3_stolen_size),
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2013-11-13 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 18:17 [PATCH] x86/early quirk: use gen6 stolen detection for VLV Jesse Barnes
2013-11-13 19:22 ` Ville Syrjälä [this message]
2013-11-13 19:22   ` [Intel-gfx] " Ville Syrjälä
2013-11-13 20:37   ` Daniel Vetter
2013-11-13 20:37     ` [Intel-gfx] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113192259.GI7819@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.