From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm64: advertise CPU features for modalias matching
Date: Thu, 14 Nov 2013 15:29:07 +0000 [thread overview]
Message-ID: <20131114152907.GL20261@arm.com> (raw)
In-Reply-To: <1384165175-16134-5-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Nov 11, 2013 at 10:19:35AM +0000, Ard Biesheuvel wrote:
> +ssize_t arch_print_cpu_modalias(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + unsigned int caps;
> + ssize_t n;
> + int i;
> +
> + /*
> + * With 32 features maximum (taking 5 bytes each to print), we don't
> + * need to worry about overrunning the PAGE_SIZE sized buffer.
> + */
> + n = sprintf(buf, "cpu:type:arm64:feature:");
I would use "aarch64" here instead of arm64 for consistency with the
architecture mode, compiler triplet and ELF_PLATFORM definition in the
kernel.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"steve.capper@linaro.org" <steve.capper@linaro.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Dave P Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH 4/4] arm64: advertise CPU features for modalias matching
Date: Thu, 14 Nov 2013 15:29:07 +0000 [thread overview]
Message-ID: <20131114152907.GL20261@arm.com> (raw)
In-Reply-To: <1384165175-16134-5-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Nov 11, 2013 at 10:19:35AM +0000, Ard Biesheuvel wrote:
> +ssize_t arch_print_cpu_modalias(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + unsigned int caps;
> + ssize_t n;
> + int i;
> +
> + /*
> + * With 32 features maximum (taking 5 bytes each to print), we don't
> + * need to worry about overrunning the PAGE_SIZE sized buffer.
> + */
> + n = sprintf(buf, "cpu:type:arm64:feature:");
I would use "aarch64" here instead of arm64 for consistency with the
architecture mode, compiler triplet and ELF_PLATFORM definition in the
kernel.
--
Catalin
next prev parent reply other threads:[~2013-11-14 15:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 10:19 [PATCH 0/4] wire up CPU features to udev based module loading Ard Biesheuvel
2013-11-11 10:19 ` Ard Biesheuvel
2013-11-11 10:19 ` [PATCH 1/4] x86: move arch_cpu_uevent() to generic code Ard Biesheuvel
2013-11-11 10:19 ` Ard Biesheuvel
2013-11-11 10:19 ` [PATCH 2/4] cpu: advertise CPU features over udev in a generic way Ard Biesheuvel
2013-11-11 10:19 ` Ard Biesheuvel
2013-11-11 10:19 ` [PATCH 3/4] x86: align with generic cpu modalias Ard Biesheuvel
2013-11-11 10:19 ` Ard Biesheuvel
2013-11-11 10:19 ` [PATCH 4/4] arm64: advertise CPU features for modalias matching Ard Biesheuvel
2013-11-11 10:19 ` Ard Biesheuvel
2013-11-14 15:29 ` Catalin Marinas [this message]
2013-11-14 15:29 ` Catalin Marinas
2013-11-14 16:14 ` Ard Biesheuvel
2013-11-14 16:14 ` Ard Biesheuvel
2013-11-14 19:05 ` H. Peter Anvin
2013-11-14 19:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114152907.GL20261@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.