From: Mel Gorman <mgorman@suse.de>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, akpm@linux-foundation.org,
dhillf@gmail.com, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages
Date: Fri, 15 Nov 2013 09:57:31 +0000 [thread overview]
Message-ID: <20131115095731.GC26002@suse.de> (raw)
In-Reply-To: <20131114233358.2B10EA33@viggo.jf.intel.com>
On Thu, Nov 14, 2013 at 03:33:58PM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> Dave Jiang reported that he was seeing oopses when running
> NUMA systems and default_hugepagesz=1G. I traced the issue down
> to migrate_page_copy() trying to use the same code for hugetlb
> pages and transparent hugepages. It should not have been trying
> to pass thp pages in there.
>
> So, add some VM_BUG_ON()s for the next hapless VM developer that
> tries the same thing.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, akpm@linux-foundation.org,
dhillf@gmail.com, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages
Date: Fri, 15 Nov 2013 09:57:31 +0000 [thread overview]
Message-ID: <20131115095731.GC26002@suse.de> (raw)
In-Reply-To: <20131114233358.2B10EA33@viggo.jf.intel.com>
On Thu, Nov 14, 2013 at 03:33:58PM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> Dave Jiang reported that he was seeing oopses when running
> NUMA systems and default_hugepagesz=1G. I traced the issue down
> to migrate_page_copy() trying to use the same code for hugetlb
> pages and transparent hugepages. It should not have been trying
> to pass thp pages in there.
>
> So, add some VM_BUG_ON()s for the next hapless VM developer that
> tries the same thing.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-11-15 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 23:33 [PATCH 0/2] v2: fix hugetlb vs. anon-thp copy page Dave Hansen
2013-11-14 23:33 ` Dave Hansen
2013-11-14 23:33 ` [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-11-14 23:33 ` Dave Hansen
2013-11-15 9:57 ` Mel Gorman [this message]
2013-11-15 9:57 ` Mel Gorman
2013-11-14 23:34 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-14 23:34 ` Dave Hansen
2013-11-15 10:26 ` Mel Gorman
2013-11-15 10:26 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 22:16 [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-10-28 22:16 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115095731.GC26002@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=dave@sr71.net \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.