From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/i915: retrieve current fb config into new plane_config structure at init v2
Date: Fri, 15 Nov 2013 10:11:04 -0800 [thread overview]
Message-ID: <20131115101104.532859b4@jbarnes-desktop> (raw)
In-Reply-To: <20131114164421.27bf665e@bpaauwe-desk.fm.intel.com>
On Thu, 14 Nov 2013 16:44:21 -0800
Bob Paauwe <bob.j.paauwe@intel.com> wrote:
> > +struct intel_plane_config {
> > + int pixel_format; /* DRM fourcc code */
>
> Comment isn't right unless I'm missing something. Looks like this pixel
> format is set to the intel pixel format values, not the DRM fourcc
> values.
>
Stale comment, I changed my mind on what to store here. Thanks for
catching it.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-11-15 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 0:04 [PATCH 1/5] drm/i915: make pitch_for_width take a tiled arg v2 Jesse Barnes
2013-11-15 0:04 ` [PATCH 2/5] drm/i915: split fb allocation and initialization v2 Jesse Barnes
2013-11-15 0:04 ` [PATCH 3/5] drm/i915: retrieve current fb config into new plane_config structure at init v2 Jesse Barnes
2013-11-15 0:26 ` Daniel Vetter
2013-11-15 0:44 ` Bob Paauwe
2013-11-15 18:11 ` Jesse Barnes [this message]
2013-11-15 0:04 ` [PATCH 4/5] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon Jesse Barnes
2013-11-15 0:29 ` Daniel Vetter
2013-11-15 9:40 ` Chris Wilson
2013-11-15 0:04 ` [PATCH 5/5] drm/i915: don't memset the fb buffer if preallocated Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115101104.532859b4@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.