From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel
<linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: Fallback to of_node of parent
Date: Sat, 16 Nov 2013 17:06:02 +0100 [thread overview]
Message-ID: <20131116160601.GA8723@katana> (raw)
In-Reply-To: <528791EF.9060505-oZ8rN/sblLk@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
> + if (!dev->of_node && dev->parent)
> + dev->of_node = dev->parent->of_node;
> +
That is not enough. Current drivers could then have the assignment
removed and even more important, this behaviour should be documented.
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Florian Meier <florian.meier@koalo.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
linux-i2c@vger.kernel.org,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Fallback to of_node of parent
Date: Sat, 16 Nov 2013 17:06:02 +0100 [thread overview]
Message-ID: <20131116160601.GA8723@katana> (raw)
In-Reply-To: <528791EF.9060505@koalo.de>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
> + if (!dev->of_node && dev->parent)
> + dev->of_node = dev->parent->of_node;
> +
That is not enough. Current drivers could then have the assignment
removed and even more important, this behaviour should be documented.
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-16 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 15:40 [PATCH] i2c: Fallback to of_node of parent Florian Meier
2013-11-16 15:40 ` Florian Meier
[not found] ` <528791EF.9060505-oZ8rN/sblLk@public.gmane.org>
2013-11-16 16:06 ` Wolfram Sang [this message]
2013-11-16 16:06 ` Wolfram Sang
2013-11-16 16:11 ` Florian Meier
2013-11-16 16:11 ` Florian Meier
[not found] ` <CABDT8WzUoPmPzDnjD3w+Oj=jUVcMf91+toWDS+hK6CrXLveCFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-16 16:59 ` Florian Meier
2013-11-16 16:59 ` Florian Meier
2013-11-25 8:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131116160601.GA8723@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=florian.meier-oZ8rN/sblLk@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.