From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Derek Basehore
<dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay
Date: Mon, 18 Nov 2013 10:43:43 +0000 [thread overview]
Message-ID: <20131118104343.GG13640@lee--X1> (raw)
In-Reply-To: <1384770649-8593-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Mon, 18 Nov 2013, Thierry Reding wrote:
> From: Derek Basehore <dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> 50 us is not a long enough delay between EC transactions. At least 70 us
> are needed for the 16 MHz STM32L part. Increase the delay to 200 us for
> an extra safety margin.
>
> Signed-off-by: Derek Basehore <dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Reviewed-by: Randall Spangler <rspangler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/mfd/cros_ec_spi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
As I'm sure you've tested this and you didn't notice any new undue
latency, I'll apply the patch, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Derek Basehore <dbasehore@chromium.org>
Subject: Re: [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay
Date: Mon, 18 Nov 2013 10:43:43 +0000 [thread overview]
Message-ID: <20131118104343.GG13640@lee--X1> (raw)
In-Reply-To: <1384770649-8593-2-git-send-email-treding@nvidia.com>
On Mon, 18 Nov 2013, Thierry Reding wrote:
> From: Derek Basehore <dbasehore@chromium.org>
>
> 50 us is not a long enough delay between EC transactions. At least 70 us
> are needed for the 16 MHz STM32L part. Increase the delay to 200 us for
> an extra safety margin.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> Reviewed-by: Randall Spangler <rspangler@chromium.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mfd/cros_ec_spi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
As I'm sure you've tested this and you didn't notice any new undue
latency, I'll apply the patch, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-18 10:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 10:30 [PATCH 1/3] mfd: cros ec: spi: Add delay for raising CS Thierry Reding
[not found] ` <1384770649-8593-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-18 10:30 ` [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay Thierry Reding
2013-11-18 10:30 ` Thierry Reding
[not found] ` <1384770649-8593-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-18 10:43 ` Lee Jones [this message]
2013-11-18 10:43 ` Lee Jones
2013-11-18 18:55 ` dbasehore .
[not found] ` <CAGAzgsrUedg7pGXpS6VaWkHeYjvcyio7byeEZ=88t3U1XzbsPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-18 19:01 ` Lee Jones
2013-11-18 19:01 ` Lee Jones
2013-11-18 10:30 ` [PATCH 3/3] mfd: cros ec: spi: Fix debug output Thierry Reding
2013-11-18 10:30 ` Thierry Reding
[not found] ` <1384770649-8593-3-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-18 10:42 ` Lee Jones
2013-11-18 10:42 ` Lee Jones
2013-11-18 11:48 ` [PATCH 1/3] mfd: cros ec: spi: Add delay for raising CS Mark Rutland
2013-11-18 11:48 ` Mark Rutland
[not found] ` <20131118114810.GE30853-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-11-19 8:42 ` Thierry Reding
2013-11-19 8:42 ` Thierry Reding
2013-11-19 17:06 ` Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118104343.GG13640@lee--X1 \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.