From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] mfd: ab8500-debugfs: move dereference after check for NULL
Date: Tue, 19 Nov 2013 08:24:10 +0000 [thread overview]
Message-ID: <20131119082410.GV13640@lee--X1> (raw)
In-Reply-To: <CACRpkdZ3GbUCkK3mte3wM_WCmtuvOvCYfu2PkJSy+7yhx_qpqQ@mail.gmail.com>
On Tue, 19 Nov 2013, Linus Walleij wrote:
> On Wed, Nov 13, 2013 at 8:40 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > We dereference "desc" before check if it is NULL. I've shifted it
> > around so we check first before dereferencing.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > I am not able to compile this.
>
> Looks and compiles good.
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>
> Lee are you queueing this?
This one slipped through the net, thanks for bringing it to my attention.
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] mfd: ab8500-debugfs: move dereference after check for NULL
Date: Tue, 19 Nov 2013 08:24:10 +0000 [thread overview]
Message-ID: <20131119082410.GV13640@lee--X1> (raw)
In-Reply-To: <CACRpkdZ3GbUCkK3mte3wM_WCmtuvOvCYfu2PkJSy+7yhx_qpqQ@mail.gmail.com>
On Tue, 19 Nov 2013, Linus Walleij wrote:
> On Wed, Nov 13, 2013 at 8:40 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > We dereference "desc" before check if it is NULL. I've shifted it
> > around so we check first before dereferencing.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > I am not able to compile this.
>
> Looks and compiles good.
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>
> Lee are you queueing this?
This one slipped through the net, thanks for bringing it to my attention.
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-19 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 7:40 [patch] mfd: ab8500-debugfs: move dereference after check for NULL Dan Carpenter
2013-11-13 7:40 ` Dan Carpenter
2013-11-19 8:07 ` Linus Walleij
2013-11-19 8:07 ` Linus Walleij
2013-11-19 8:24 ` Lee Jones [this message]
2013-11-19 8:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119082410.GV13640@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.