From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Custer <jcuster@sgi.com>
Cc: linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jiang Liu <jiang.liu@huawei.com>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reimplement old functionality of vm_munmap to vm_munmap_mm
Date: Tue, 19 Nov 2013 17:04:16 +0000 [thread overview]
Message-ID: <20131119170416.GD10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1384878592-194909-1-git-send-email-jcuster@sgi.com>
On Tue, Nov 19, 2013 at 10:29:52AM -0600, James Custer wrote:
> Commit bfce281c287a427d0841fadf5d59242757b4e620 killed the mm parameter to
> vm_munmap. Although the mm parameter was not used in any in-tree kernel
> modules, it is used by some out-of-tree modules.
>
> We create a new function vm_munmap_mm that has the same functionality as
> vm_munmap, whereas vm_munmap uses current->mm, vm_munmap_mm takes the mm as
> a paramter.
>
> Since this is a newly exported symbol it is marked EXPORT_SYMBOL_GPL.
Which modules and what are they doing with it? More to the point,
what prevents races with e.g. dumping core? And that's not an idle
question - for example, fs/aio.c used to contain very unpleasant
races of that kind exactly because it was playing games with modifying
->mm other than current->mm.
In other words, NAK.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Custer <jcuster@sgi.com>
Cc: linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jiang Liu <jiang.liu@huawei.com>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reimplement old functionality of vm_munmap to vm_munmap_mm
Date: Tue, 19 Nov 2013 17:04:16 +0000 [thread overview]
Message-ID: <20131119170416.GD10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1384878592-194909-1-git-send-email-jcuster@sgi.com>
On Tue, Nov 19, 2013 at 10:29:52AM -0600, James Custer wrote:
> Commit bfce281c287a427d0841fadf5d59242757b4e620 killed the mm parameter to
> vm_munmap. Although the mm parameter was not used in any in-tree kernel
> modules, it is used by some out-of-tree modules.
>
> We create a new function vm_munmap_mm that has the same functionality as
> vm_munmap, whereas vm_munmap uses current->mm, vm_munmap_mm takes the mm as
> a paramter.
>
> Since this is a newly exported symbol it is marked EXPORT_SYMBOL_GPL.
Which modules and what are they doing with it? More to the point,
what prevents races with e.g. dumping core? And that's not an idle
question - for example, fs/aio.c used to contain very unpleasant
races of that kind exactly because it was playing games with modifying
->mm other than current->mm.
In other words, NAK.
next prev parent reply other threads:[~2013-11-19 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 16:29 [PATCH] Reimplement old functionality of vm_munmap to vm_munmap_mm James Custer
2013-11-19 16:29 ` James Custer
2013-11-19 16:31 ` Christoph Hellwig
2013-11-19 16:31 ` Christoph Hellwig
2013-11-19 17:04 ` Al Viro [this message]
2013-11-19 17:04 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119170416.GD10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hughd@google.com \
--cc=jcuster@sgi.com \
--cc=jiang.liu@huawei.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.