* Re: [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision [not found] <tip-ce5dae03973461e2a42098c53d62946b98baab42@git.kernel.org> @ 2013-11-19 18:42 ` Russell King 2013-11-19 19:12 ` Ingo Molnar 0 siblings, 1 reply; 2+ messages in thread From: Russell King @ 2013-11-19 18:42 UTC (permalink / raw) To: linux-kernel, mingo, hpa, voice.shen, sboyd, akpm, tglx; +Cc: linux-tip-commits On Tue, Nov 19, 2013 at 10:12:23AM -0800, tip-bot for Stephen Boyd wrote: > + /* > + * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as > + * 1832Khz How about getting proper SI units. Hertz is Hz - that's capital H and lower case z. It's also the surname of an engineer. Kilo is always lower case k. Therefore, the unit of 1000 cycles per second is kHz and not KHZ, khz, Khz, khZ or any other stupid mixture of cases. Given that we are programmers, and programming computers requires an attention to detail, completely ignoring such detail when it comes to SI units is extremely poor - and suggests that we are illerate. May I suggest more care is taken in the future? -- Russell King ARM architecture Linux Kernel maintainer ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision 2013-11-19 18:42 ` [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision Russell King @ 2013-11-19 19:12 ` Ingo Molnar 0 siblings, 0 replies; 2+ messages in thread From: Ingo Molnar @ 2013-11-19 19:12 UTC (permalink / raw) To: Russell King Cc: linux-kernel, hpa, voice.shen, sboyd, akpm, tglx, linux-tip-commits * Russell King <rmk@arm.linux.org.uk> wrote: > On Tue, Nov 19, 2013 at 10:12:23AM -0800, tip-bot for Stephen Boyd wrote: > > + /* > > + * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as > > + * 1832Khz > > How about getting proper SI units. Note that I objected to this patch earlier today, I think this code should look differently - so your objection to this particular patch is mooted. Thanks, Ingo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-19 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tip-ce5dae03973461e2a42098c53d62946b98baab42@git.kernel.org>
2013-11-19 18:42 ` [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision Russell King
2013-11-19 19:12 ` Ingo Molnar
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.