From: "Pali Rohár" <pali.rohar@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] afs: proc cells and rootcell are writeable
Date: Wed, 20 Nov 2013 14:30:55 +0100 [thread overview]
Message-ID: <201311201430.56135@pali> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 817 bytes --]
Both proc files are writeable and used for configuring cells. But
there is missing correct mode flag for writeable files. Without
this patch both proc files are read only.
diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index 526e4bb..276cb6e 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -147,11 +147,11 @@ int afs_proc_init(void)
if (!proc_afs)
goto error_dir;
- p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops);
+ p = proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_cells_fops);
if (!p)
goto error_cells;
- p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops);
+ p = proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_rootcell_fops);
if (!p)
goto error_rootcell;
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2013-11-20 13:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 13:30 Pali Rohár [this message]
2013-12-10 8:02 ` [PATCH] afs: proc cells and rootcell are writeable Pali Rohár
2013-12-16 7:00 ` Andrew Morton
2013-12-17 13:19 ` Pali Rohár
2013-12-17 18:31 ` David Howells
2013-12-31 9:59 ` Pali Rohár
-- strict thread matches above, loose matches on Subject: below --
2014-01-26 12:27 David Howells
2014-01-26 19:23 ` Linus Torvalds
2014-01-26 20:19 ` Ingo Molnar
2014-01-26 20:22 ` Ingo Molnar
2014-01-26 20:25 ` Ingo Molnar
2014-01-28 8:39 ` Geert Uytterhoeven
2014-01-28 12:04 ` Ingo Molnar
2014-01-28 12:17 ` Geert Uytterhoeven
2014-01-28 12:20 ` Ingo Molnar
2014-01-28 17:34 ` Joe Perches
2014-01-28 20:20 ` David Howells
2014-01-28 20:27 ` Al Viro
2014-01-28 20:56 ` David Howells
2014-01-30 21:48 ` Eric W. Biederman
2014-01-30 21:50 ` Linus Torvalds
2014-01-30 22:15 ` Pali Rohár
2014-01-30 22:27 ` Linus Torvalds
2014-01-30 22:36 ` Dave Jones
2014-01-30 22:33 ` Russ Allbery
2014-01-31 0:21 ` David Howells
2014-01-31 0:28 ` David Howells
2014-01-31 0:31 ` David Howells
2014-01-31 0:07 ` David Howells
2014-01-31 0:20 ` David Howells
2014-01-27 12:33 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311201430.56135@pali \
--to=pali.rohar@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.