[PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

[PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

[Mrinmayee Hingolikar]

Signed-off-by: Mrinmayee Hingolikar <mrinmayee@ti.com>
---
 recipes-ti/libdce/libdce_git.bb |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 recipes-ti/libdce/libdce_git.bb

diff --git a/recipes-ti/libdce/libdce_git.bb b/recipes-ti/libdce/libdce_git.bb
new file mode 100644
index 0000000..fcb9984
--- /dev/null
+++ b/recipes-ti/libdce/libdce_git.bb
@@ -0,0 +1,14 @@
+inherit autotools pkgconfig
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://libdce.h;beginline=1;endline=31;md5=0a398cf815b8b5f31f552266cd453dae"
+
+PR = "r0"
+
+DEPENDS = "libdrm ti-ipc"
+
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
+SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"
+
+S = "${WORKDIR}/git"
+EXTRA_OECONF += "IPC_HEADERS=${STAGING_DIR_TARGET}/usr/include/ti/ipc/mm"
-- 
1.7.9.5

Re: [PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

[Denys Dmytriyenko]

First of all:

Acked-by: Denys Dmytriyenko <denys@ti.com>

Second, couple minor comments:

1. Please use "name: short summary" for the patch subject. No need for nested 
"ti: libdce: ". And the summary could have been shorter - you could have added 
a more expanded description separately...

2. inherit line usually goes after LICENSE, LIC_FILES_CHKSUM. And you are 
missing more generic, but optional SUMMARY, DESCRIPTION,  HOMEPAGE and SECTION

Other than that - very good, I can take it and fix the minor comments myself.

-- 
Denys


On Wed, Nov 20, 2013 at 04:08:52PM +0530, Mrinmayee Hingolikar wrote:
> Signed-off-by: Mrinmayee Hingolikar <mrinmayee@ti.com>
> ---
>  recipes-ti/libdce/libdce_git.bb |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 recipes-ti/libdce/libdce_git.bb
> 
> diff --git a/recipes-ti/libdce/libdce_git.bb b/recipes-ti/libdce/libdce_git.bb
> new file mode 100644
> index 0000000..fcb9984
> --- /dev/null
> +++ b/recipes-ti/libdce/libdce_git.bb
> @@ -0,0 +1,14 @@
> +inherit autotools pkgconfig
> +
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://libdce.h;beginline=1;endline=31;md5=0a398cf815b8b5f31f552266cd453dae"
> +
> +PR = "r0"
> +
> +DEPENDS = "libdrm ti-ipc"
> +
> +SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
> +SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"
> +
> +S = "${WORKDIR}/git"
> +EXTRA_OECONF += "IPC_HEADERS=${STAGING_DIR_TARGET}/usr/include/ti/ipc/mm"
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

[Nicolas Dechesne]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

On Wed, Nov 20, 2013 at 11:38 AM, Mrinmayee Hingolikar <mrinmayee@ti.com>wrote:

> +SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
> +SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"
>

i guess you need to set PV, it might default to 1.0 otherwise.

[-- Attachment #2: Type: text/html, Size: 746 bytes --]

Re: [PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

[Maupin, Chase]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-bounces@yoctoproject.org] On Behalf Of Nicolas Dechesne
Sent: Wednesday, November 20, 2013 4:06 PM
To: Hingolikar, Mrinmayee
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.


On Wed, Nov 20, 2013 at 11:38 AM, Mrinmayee Hingolikar <mrinmayee@ti.com<mailto:mrinmayee@ti.com>> wrote:
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git<http://git.ti.com/glsdk/libdce2.git;protocol=git>"
+SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"

i guess you need to set PV, it might default to 1.0 otherwise.

[CEM] Good point Nicolas



[-- Attachment #2: Type: text/html, Size: 3719 bytes --]