From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Michael Dalton <mwdalton@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net] virtio-net: fix page refcnt leaking when fail to allocate frag skb
Date: Wed, 20 Nov 2013 19:03:33 +0200 [thread overview]
Message-ID: <20131120170333.GA21972@redhat.com> (raw)
In-Reply-To: <1384964061.8604.151.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Nov 20, 2013 at 08:14:21AM -0800, Eric Dumazet wrote:
> On Wed, 2013-11-20 at 18:06 +0200, Michael S. Tsirkin wrote:
>
> > Hmm some kind of disconnect here.
> > I got you rmanagement about bufferbloat.
> >
> > What I am saying is that maybe we should drop packets more
> > aggressively: when we drop one packet of a flow, why not
> > drop everything that's queued and is for the same flow?
>
> I really hope your TCP flows use SACK ;)
>
> Please read the rfc 2018 introduction for details.
>
> If a packet is dropped, it doesn't mean following packets _have_ to be
> dropped.
Got it, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Dalton <mwdalton@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net] virtio-net: fix page refcnt leaking when fail to allocate frag skb
Date: Wed, 20 Nov 2013 19:03:33 +0200 [thread overview]
Message-ID: <20131120170333.GA21972@redhat.com> (raw)
In-Reply-To: <1384964061.8604.151.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Nov 20, 2013 at 08:14:21AM -0800, Eric Dumazet wrote:
> On Wed, 2013-11-20 at 18:06 +0200, Michael S. Tsirkin wrote:
>
> > Hmm some kind of disconnect here.
> > I got you rmanagement about bufferbloat.
> >
> > What I am saying is that maybe we should drop packets more
> > aggressively: when we drop one packet of a flow, why not
> > drop everything that's queued and is for the same flow?
>
> I really hope your TCP flows use SACK ;)
>
> Please read the rfc 2018 introduction for details.
>
> If a packet is dropped, it doesn't mean following packets _have_ to be
> dropped.
Got it, thanks.
next prev parent reply other threads:[~2013-11-20 17:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 8:05 [PATCH net] virtio-net: fix page refcnt leaking when fail to allocate frag skb Jason Wang
2013-11-19 8:05 ` Jason Wang
2013-11-19 14:03 ` Eric Dumazet
2013-11-19 14:03 ` Eric Dumazet
2013-11-19 18:44 ` Michael S. Tsirkin
2013-11-19 18:44 ` Michael S. Tsirkin
2013-11-19 20:49 ` Michael S. Tsirkin
2013-11-19 20:49 ` Michael S. Tsirkin
2013-11-19 21:36 ` Eric Dumazet
2013-11-19 21:36 ` Eric Dumazet
2013-11-19 21:53 ` Michael S. Tsirkin
2013-11-19 21:53 ` Michael S. Tsirkin
2013-11-19 22:00 ` Eric Dumazet
2013-11-19 22:00 ` Eric Dumazet
2013-11-20 1:34 ` Michael Dalton
2013-11-20 1:34 ` Michael Dalton
2013-11-20 3:17 ` Jason Wang
2013-11-20 3:17 ` Jason Wang
2013-11-20 9:00 ` Michael S. Tsirkin
2013-11-20 9:00 ` Michael S. Tsirkin
2013-11-20 8:58 ` Michael S. Tsirkin
2013-11-20 8:58 ` Michael S. Tsirkin
2013-11-20 15:16 ` Eric Dumazet
2013-11-20 15:16 ` Eric Dumazet
2013-11-20 16:06 ` Michael S. Tsirkin
2013-11-20 16:06 ` Michael S. Tsirkin
2013-11-20 16:14 ` Eric Dumazet
2013-11-20 16:14 ` Eric Dumazet
2013-11-20 17:03 ` Michael S. Tsirkin [this message]
2013-11-20 17:03 ` Michael S. Tsirkin
2013-11-19 21:38 ` Michael Dalton
2013-11-19 21:38 ` Michael Dalton
2013-11-20 9:06 ` Michael S. Tsirkin
2013-11-20 9:06 ` Michael S. Tsirkin
2013-11-20 3:05 ` Jason Wang
2013-11-20 3:05 ` Jason Wang
2013-11-20 3:00 ` Jason Wang
2013-11-20 3:00 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120170333.GA21972@redhat.com \
--to=mst@redhat.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.