From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] mtd: gpmc: add BCH support for plain AM335x
Date: Wed, 20 Nov 2013 14:57:34 -0300 [thread overview]
Message-ID: <20131120175733.GA27064@localhost> (raw)
In-Reply-To: <1384969152-10411-1-git-send-email-wsa@the-dreams.de>
Hey Wolfram:
On Wed, Nov 20, 2013 at 06:39:12PM +0100, Wolfram Sang wrote:
> When building a kernel without OMAP3 support but only AM335x, we can't
> activate the needed MTD_NAND_OMAP_BCH symbol.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Actually, I wonder if this is fix will scale. Maybe someone with more insight
> about TI SoCs could find a better expression of supported SoCs. This is the
> only one I could test .
>
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 93ae6a6..f9455e4 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -95,7 +95,7 @@ config MTD_NAND_OMAP2
> platforms.
>
> config MTD_NAND_OMAP_BCH
> - depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3
> + depends on MTD_NAND && MTD_NAND_OMAP2 && (ARCH_OMAP3 || SOC_AM33XX)
> tristate "Support hardware based BCH error correction"
> default n
> select BCH
> --
> 1.8.4.2
>
A similar patch has been already merged and you can pick it from l2-mtd
next branch:
http://git.infradead.org/l2-mtd.git/commitdiff/1900cdf03057030497e967614c4b19296b6ac460
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-mtd@lists.infradead.org, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] mtd: gpmc: add BCH support for plain AM335x
Date: Wed, 20 Nov 2013 14:57:34 -0300 [thread overview]
Message-ID: <20131120175733.GA27064@localhost> (raw)
In-Reply-To: <1384969152-10411-1-git-send-email-wsa@the-dreams.de>
Hey Wolfram:
On Wed, Nov 20, 2013 at 06:39:12PM +0100, Wolfram Sang wrote:
> When building a kernel without OMAP3 support but only AM335x, we can't
> activate the needed MTD_NAND_OMAP_BCH symbol.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Actually, I wonder if this is fix will scale. Maybe someone with more insight
> about TI SoCs could find a better expression of supported SoCs. This is the
> only one I could test .
>
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 93ae6a6..f9455e4 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -95,7 +95,7 @@ config MTD_NAND_OMAP2
> platforms.
>
> config MTD_NAND_OMAP_BCH
> - depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3
> + depends on MTD_NAND && MTD_NAND_OMAP2 && (ARCH_OMAP3 || SOC_AM33XX)
> tristate "Support hardware based BCH error correction"
> default n
> select BCH
> --
> 1.8.4.2
>
A similar patch has been already merged and you can pick it from l2-mtd
next branch:
http://git.infradead.org/l2-mtd.git/commitdiff/1900cdf03057030497e967614c4b19296b6ac460
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] mtd: gpmc: add BCH support for plain AM335x
Date: Wed, 20 Nov 2013 14:57:34 -0300 [thread overview]
Message-ID: <20131120175733.GA27064@localhost> (raw)
In-Reply-To: <1384969152-10411-1-git-send-email-wsa@the-dreams.de>
Hey Wolfram:
On Wed, Nov 20, 2013 at 06:39:12PM +0100, Wolfram Sang wrote:
> When building a kernel without OMAP3 support but only AM335x, we can't
> activate the needed MTD_NAND_OMAP_BCH symbol.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Actually, I wonder if this is fix will scale. Maybe someone with more insight
> about TI SoCs could find a better expression of supported SoCs. This is the
> only one I could test .
>
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 93ae6a6..f9455e4 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -95,7 +95,7 @@ config MTD_NAND_OMAP2
> platforms.
>
> config MTD_NAND_OMAP_BCH
> - depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3
> + depends on MTD_NAND && MTD_NAND_OMAP2 && (ARCH_OMAP3 || SOC_AM33XX)
> tristate "Support hardware based BCH error correction"
> default n
> select BCH
> --
> 1.8.4.2
>
A similar patch has been already merged and you can pick it from l2-mtd
next branch:
http://git.infradead.org/l2-mtd.git/commitdiff/1900cdf03057030497e967614c4b19296b6ac460
Thanks!
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-20 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 17:39 [RFC] mtd: gpmc: add BCH support for plain AM335x Wolfram Sang
2013-11-20 17:39 ` Wolfram Sang
2013-11-20 17:39 ` Wolfram Sang
2013-11-20 17:57 ` Ezequiel Garcia [this message]
2013-11-20 17:57 ` Ezequiel Garcia
2013-11-20 17:57 ` Ezequiel Garcia
2013-11-20 18:27 ` Wolfram Sang
2013-11-20 18:27 ` Wolfram Sang
2013-11-20 18:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120175733.GA27064@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.