From: Guenter Roeck <linux@roeck-us.net>
To: Markus Mayer <markus.mayer@linaro.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Christian Daudt <bcm@fixthebug.org>,
Linaro Patches <patches@linaro.org>,
Matt Porter <matt.porter@linaro.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Linux Watchdog List <linux-watchdog@vger.kernel.org>,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver
Date: Wed, 20 Nov 2013 10:40:34 -0800 [thread overview]
Message-ID: <20131120184034.GC30952@roeck-us.net> (raw)
In-Reply-To: <CAPdLdq=xUjsr1ykTHh3t_Uy9kBkKXbW0gpAmtgiOfj8gC42yeA@mail.gmail.com>
On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote:
> > Hi Markus,
> >
> > Yes, I noticed when I merged it into my watchdog-next branch.
> >
> > Reminds me ... v3 had a whitespace problem. I don't recall if you fixed
> > that in v4. If you didn't, that might be a better reason to send v5.
>
> That's still there, unfortunately. Trailing space on the first
> help-text line in Kconfig:
> Support for the watchdog timer on the following Broadcom BCM281xx
>
> So, I'll generate v5 with that fixed. Do you prefer I also rebase it
> right now to whatever current tip is to take care of the merge
> conflict?
>
I would suggest to wait for -rc1 and rebase to it before you send the new
version. After all, it won't make it into 3.13 anyway, so no need to hurry.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver
Date: Wed, 20 Nov 2013 10:40:34 -0800 [thread overview]
Message-ID: <20131120184034.GC30952@roeck-us.net> (raw)
In-Reply-To: <CAPdLdq=xUjsr1ykTHh3t_Uy9kBkKXbW0gpAmtgiOfj8gC42yeA@mail.gmail.com>
On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote:
> > Hi Markus,
> >
> > Yes, I noticed when I merged it into my watchdog-next branch.
> >
> > Reminds me ... v3 had a whitespace problem. I don't recall if you fixed
> > that in v4. If you didn't, that might be a better reason to send v5.
>
> That's still there, unfortunately. Trailing space on the first
> help-text line in Kconfig:
> Support for the watchdog timer on the following Broadcom BCM281xx
>
> So, I'll generate v5 with that fixed. Do you prefer I also rebase it
> right now to whatever current tip is to take care of the merge
> conflict?
>
I would suggest to wait for -rc1 and rebase to it before you send the new
version. After all, it won't make it into 3.13 anyway, so no need to hurry.
Thanks,
Guenter
next prev parent reply other threads:[~2013-11-20 18:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 19:07 [PATCH v4 0/2] watchdog: bcm281xx: Watchdog Driver Markus Mayer
2013-11-19 19:07 ` Markus Mayer
2013-11-19 19:07 ` [PATCH v4 1/2] " Markus Mayer
2013-11-19 19:07 ` Markus Mayer
2013-11-20 16:12 ` Markus Mayer
2013-11-20 16:12 ` Markus Mayer
2013-11-20 16:27 ` Guenter Roeck
2013-11-20 16:27 ` Guenter Roeck
2013-11-20 18:24 ` Markus Mayer
2013-11-20 18:24 ` Markus Mayer
2013-11-20 18:40 ` Guenter Roeck [this message]
2013-11-20 18:40 ` Guenter Roeck
2013-11-20 18:42 ` Markus Mayer
2013-11-20 18:42 ` Markus Mayer
2013-11-19 19:07 ` [PATCH v4 2/2] ARM: bcm281xx: watchdog configuration Markus Mayer
2013-11-19 19:07 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120184034.GC30952@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcm@fixthebug.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=patches@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.