From: Arnd Bergmann <arnd@arndb.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Loc Ho <lho@apm.com>,
olof@lixom.net, tj@kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
Tuan Phan <tphan@apm.com>, Suman Tripathi <stripathi@apm.com>
Subject: Re: [PATCH v2 4/4] arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries
Date: Wed, 20 Nov 2013 19:48:20 +0100 [thread overview]
Message-ID: <201311201948.20682.arnd@arndb.de> (raw)
In-Reply-To: <528CF956.3040104@cogentembedded.com>
On Wednesday 20 November 2013, Sergei Shtylyov wrote:
> > --- a/arch/arm64/boot/dts/apm-storm.dtsi
> > +++ b/arch/arm64/boot/dts/apm-storm.dtsi
> > @@ -193,5 +193,33 @@
> > reg = <0x0 0x17000014 0x0 0x100>;
> > mask = <0x1>;
> > };
> > +
> > + sataphy0: sataphy@1f210000 {
>
> The nodes should better be named like "sata-phy@1f210000" to better comply
> with the "ethernet-phy" name we see in the ePAPR spec.
Well, since the phy can be used for other devices, I'd rather name it just
"phy", or possibly "serdes". The fact that it happens to be used for sata
here should not influence the naming when both the phy driver and the hardware
are completely generic.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries
Date: Wed, 20 Nov 2013 19:48:20 +0100 [thread overview]
Message-ID: <201311201948.20682.arnd@arndb.de> (raw)
In-Reply-To: <528CF956.3040104@cogentembedded.com>
On Wednesday 20 November 2013, Sergei Shtylyov wrote:
> > --- a/arch/arm64/boot/dts/apm-storm.dtsi
> > +++ b/arch/arm64/boot/dts/apm-storm.dtsi
> > @@ -193,5 +193,33 @@
> > reg = <0x0 0x17000014 0x0 0x100>;
> > mask = <0x1>;
> > };
> > +
> > + sataphy0: sataphy at 1f210000 {
>
> The nodes should better be named like "sata-phy at 1f210000" to better comply
> with the "ethernet-phy" name we see in the ePAPR spec.
Well, since the phy can be used for other devices, I'd rather name it just
"phy", or possibly "serdes". The fact that it happens to be used for sata
here should not influence the naming when both the phy driver and the hardware
are completely generic.
Arnd
next prev parent reply other threads:[~2013-11-20 18:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 23:53 [PATCH v2 0/4] ata: Add APM X-Gene SoC 6.0Gbps SATA PHY support Loc Ho
2013-11-19 23:53 ` Loc Ho
2013-11-19 23:53 ` [PATCH v2 1/4] PHY: Add function set_speed to generic PHY framework Loc Ho
2013-11-19 23:53 ` Loc Ho
2013-11-19 23:53 ` [PATCH v2 2/4] Documentation: Add APM X-Gene SoC 6.0Gbps SATA PHY driver binding documentation Loc Ho
2013-11-19 23:53 ` Loc Ho
2013-11-19 23:53 ` [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver Loc Ho
2013-11-19 23:53 ` Loc Ho
2013-11-19 23:53 ` [PATCH v2 4/4] arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries Loc Ho
2013-11-19 23:53 ` Loc Ho
2013-11-20 0:08 ` Loc Ho
2013-11-20 0:08 ` Loc Ho
2013-11-20 11:39 ` Mark Rutland
2013-11-20 11:39 ` Mark Rutland
2013-11-20 18:03 ` Sergei Shtylyov
2013-11-20 18:03 ` Sergei Shtylyov
2013-11-20 18:48 ` Arnd Bergmann [this message]
2013-11-20 18:48 ` Arnd Bergmann
2013-11-20 8:57 ` [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver Ming Lei
2013-11-20 8:57 ` Ming Lei
2013-11-20 19:16 ` Loc Ho
2013-11-20 19:16 ` Loc Ho
2013-11-20 11:37 ` Mark Rutland
2013-11-20 11:37 ` Mark Rutland
2013-11-20 12:06 ` Arnd Bergmann
2013-11-20 12:06 ` Arnd Bergmann
2013-11-20 15:06 ` Tejun Heo
2013-11-20 15:06 ` Tejun Heo
2013-11-20 15:41 ` Arnd Bergmann
2013-11-20 15:41 ` Arnd Bergmann
2013-11-20 15:49 ` Tejun Heo
2013-11-20 15:49 ` Tejun Heo
2013-11-20 18:46 ` Arnd Bergmann
2013-11-20 18:46 ` Arnd Bergmann
2013-11-20 22:23 ` Loc Ho
2013-11-20 22:23 ` Loc Ho
2013-11-20 9:43 ` [PATCH v2 2/4] Documentation: Add APM X-Gene SoC 6.0Gbps SATA PHY driver binding documentation Mark Rutland
2013-11-20 9:43 ` Mark Rutland
2013-11-20 20:07 ` Loc Ho
2013-11-20 20:07 ` Loc Ho
2013-11-22 9:37 ` Mark Rutland
2013-11-22 9:37 ` Mark Rutland
2013-11-20 18:06 ` [PATCH v2 1/4] PHY: Add function set_speed to generic PHY framework Sergei Shtylyov
2013-11-20 18:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311201948.20682.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
--cc=tphan@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.