Re: [PATCH 09/10] drm/i915: Set has_fbc=true for all SNB+, except VLV

[Rodrigo Vivi <rodrigo.vivi@gmail.com>]

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

On Wed, Nov 06, 2013 at 11:02:24PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> At least since SNB (perhaps even earlier) even the desktop parts
> should have FBC.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c0ab5d4..9b8c9bf 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -265,6 +265,7 @@ static const struct intel_device_info intel_ironlake_m_info = {
>  static const struct intel_device_info intel_sandybridge_d_info = {
>  	.gen = 6, .num_pipes = 2,
>  	.need_gfx_hws = 1, .has_hotplug = 1,
> +	.has_fbc = 1,
>  	.ring_mask = RENDER_RING | BSD_RING | BLT_RING,
>  	.has_llc = 1,
>  };
> @@ -280,6 +281,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
>  #define GEN7_FEATURES  \
>  	.gen = 7, .num_pipes = 3, \
>  	.need_gfx_hws = 1, .has_hotplug = 1, \
> +	.has_fbc = 1, \
>  	.ring_mask = RENDER_RING | BSD_RING | BLT_RING, \
>  	.has_llc = 1
>  
> @@ -292,7 +294,6 @@ static const struct intel_device_info intel_ivybridge_m_info = {
>  	GEN7_FEATURES,
>  	.is_ivybridge = 1,
>  	.is_mobile = 1,
> -	.has_fbc = 1,
>  };
>  
>  static const struct intel_device_info intel_ivybridge_q_info = {
> @@ -307,6 +308,7 @@ static const struct intel_device_info intel_valleyview_m_info = {
>  	.num_pipes = 2,
>  	.is_valleyview = 1,
>  	.display_mmio_offset = VLV_DISPLAY_BASE,
> +	.has_fbc = 0, /* legal, last one wins */
>  	.has_llc = 0, /* legal, last one wins */
>  };
>  
> @@ -315,6 +317,7 @@ static const struct intel_device_info intel_valleyview_d_info = {
>  	.num_pipes = 2,
>  	.is_valleyview = 1,
>  	.display_mmio_offset = VLV_DISPLAY_BASE,
> +	.has_fbc = 0, /* legal, last one wins */
>  	.has_llc = 0, /* legal, last one wins */
>  };
>  
> @@ -332,7 +335,6 @@ static const struct intel_device_info intel_haswell_m_info = {
>  	.is_mobile = 1,
>  	.has_ddi = 1,
>  	.has_fpga_dbg = 1,
> -	.has_fbc = 1,
>  	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING,
>  };
>  
> -- 
> 1.8.1.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx