All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Add pinctrl_register_mappings() for Koelsch
Date: Thu, 21 Nov 2013 04:05:57 +0000	[thread overview]
Message-ID: <20131121040555.GI31130@verge.net.au> (raw)
In-Reply-To: <20131120074148.22744.70608.sendpatchset@w520>

On Wed, Nov 20, 2013 at 04:41:48PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add code to setup the r8a7791 PFC for the Koelsch board.
> 
> At this point serial consoles are added, and in the near
> future other platform-device-only devices will be added
> here like for instance the r8a7791 DU.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  arch/arm/mach-shmobile/board-koelsch.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates
today or tomorrow.

> 
> --- 0014/arch/arm/mach-shmobile/board-koelsch.c
> +++ work/arch/arm/mach-shmobile/board-koelsch.c	2013-11-20 16:18:28.000000000 +0900
> @@ -24,6 +24,7 @@
>  #include <linux/input.h>
>  #include <linux/kernel.h>
>  #include <linux/leds.h>
> +#include <linux/pinctrl/machine.h>
>  #include <linux/platform_data/gpio-rcar.h>
>  #include <linux/platform_device.h>
>  #include <mach/common.h>
> @@ -78,9 +79,20 @@ static const struct gpio_keys_platform_d
>  	.nbuttons	= ARRAY_SIZE(gpio_buttons),
>  };
>  
> +static const struct pinctrl_map koelsch_pinctrl_map[] = {
> +	/* SCIF0 (CN19: DEBUG SERIAL0) */
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7791",
> +				  "scif0_data_d", "scif0"),
> +	/* SCIF1 (CN20: DEBUG SERIAL1) */
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7791",
> +				  "scif1_data_d", "scif1"),
> +};
> +
>  static void __init koelsch_add_standard_devices(void)
>  {
>  	r8a7791_clock_init();
> +	pinctrl_register_mappings(koelsch_pinctrl_map,
> +				  ARRAY_SIZE(koelsch_pinctrl_map));
>  	r8a7791_pinmux_init();
>  	r8a7791_add_standard_devices();
>  	platform_device_register_data(&platform_bus, "leds-gpio", -1,
> 

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Add pinctrl_register_mappings() for Koelsch
Date: Thu, 21 Nov 2013 13:05:57 +0900	[thread overview]
Message-ID: <20131121040555.GI31130@verge.net.au> (raw)
In-Reply-To: <20131120074148.22744.70608.sendpatchset@w520>

On Wed, Nov 20, 2013 at 04:41:48PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add code to setup the r8a7791 PFC for the Koelsch board.
> 
> At this point serial consoles are added, and in the near
> future other platform-device-only devices will be added
> here like for instance the r8a7791 DU.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  arch/arm/mach-shmobile/board-koelsch.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates
today or tomorrow.

> 
> --- 0014/arch/arm/mach-shmobile/board-koelsch.c
> +++ work/arch/arm/mach-shmobile/board-koelsch.c	2013-11-20 16:18:28.000000000 +0900
> @@ -24,6 +24,7 @@
>  #include <linux/input.h>
>  #include <linux/kernel.h>
>  #include <linux/leds.h>
> +#include <linux/pinctrl/machine.h>
>  #include <linux/platform_data/gpio-rcar.h>
>  #include <linux/platform_device.h>
>  #include <mach/common.h>
> @@ -78,9 +79,20 @@ static const struct gpio_keys_platform_d
>  	.nbuttons	= ARRAY_SIZE(gpio_buttons),
>  };
>  
> +static const struct pinctrl_map koelsch_pinctrl_map[] = {
> +	/* SCIF0 (CN19: DEBUG SERIAL0) */
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7791",
> +				  "scif0_data_d", "scif0"),
> +	/* SCIF1 (CN20: DEBUG SERIAL1) */
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7791",
> +				  "scif1_data_d", "scif1"),
> +};
> +
>  static void __init koelsch_add_standard_devices(void)
>  {
>  	r8a7791_clock_init();
> +	pinctrl_register_mappings(koelsch_pinctrl_map,
> +				  ARRAY_SIZE(koelsch_pinctrl_map));
>  	r8a7791_pinmux_init();
>  	r8a7791_add_standard_devices();
>  	platform_device_register_data(&platform_bus, "leds-gpio", -1,
> 

  reply	other threads:[~2013-11-21  4:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  7:41 [PATCH] ARM: shmobile: Add pinctrl_register_mappings() for Koelsch Magnus Damm
2013-11-20  7:41 ` Magnus Damm
2013-11-21  4:05 ` Simon Horman [this message]
2013-11-21  4:05   ` Simon Horman
2013-11-21  8:38   ` Simon Horman
2013-11-21  8:38     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121040555.GI31130@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.