From: "Eric Bénard" <eric@eukrea.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv9][ 3/3] ARM: dts: cpuimx35 Add touchscreen support.
Date: Thu, 21 Nov 2013 08:05:28 +0000 [thread overview]
Message-ID: <20131121090528.41af72bd@e6520eb> (raw)
In-Reply-To: <20131121050922.GF18477@ns203013.ovh.net>
Le Thu, 21 Nov 2013 06:09:22 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > + tsc2007: tsc2007@48 {
> > + compatible = "ti,tsc2007";
> > + reg = <0x48>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <0x2 0x8>;
> > + gpios = <&gpio3 2 1>;
> as explain on the binding drop this gpios this is an IRQ not a gpio
>
> NACK
>
please read the tsc2007's code, in the patch there is :
+static int tsc2007_get_pendown_state_dt(struct tsc2007 *ts)
+{
+ return !gpio_get_value(ts->gpio);
+}
+
http://www.mail-archive.com/linux-input@vger.kernel.org/msg06765.html
Eric
WARNING: multiple messages have this Message-ID (diff)
From: "Eric Bénard" <eric@eukrea.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Denis Carikli <denis@eukrea.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
devicetree@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Lothar Wa??mann <LW@KARO-electronics.de>
Subject: Re: [PATCHv9][ 3/3] ARM: dts: cpuimx35 Add touchscreen support.
Date: Thu, 21 Nov 2013 09:05:28 +0100 [thread overview]
Message-ID: <20131121090528.41af72bd@e6520eb> (raw)
In-Reply-To: <20131121050922.GF18477@ns203013.ovh.net>
Le Thu, 21 Nov 2013 06:09:22 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > + tsc2007: tsc2007@48 {
> > + compatible = "ti,tsc2007";
> > + reg = <0x48>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <0x2 0x8>;
> > + gpios = <&gpio3 2 1>;
> as explain on the binding drop this gpios this is an IRQ not a gpio
>
> NACK
>
please read the tsc2007's code, in the patch there is :
+static int tsc2007_get_pendown_state_dt(struct tsc2007 *ts)
+{
+ return !gpio_get_value(ts->gpio);
+}
+
http://www.mail-archive.com/linux-input@vger.kernel.org/msg06765.html
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv9][ 3/3] ARM: dts: cpuimx35 Add touchscreen support.
Date: Thu, 21 Nov 2013 09:05:28 +0100 [thread overview]
Message-ID: <20131121090528.41af72bd@e6520eb> (raw)
In-Reply-To: <20131121050922.GF18477@ns203013.ovh.net>
Le Thu, 21 Nov 2013 06:09:22 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a ?crit :
> > + tsc2007: tsc2007 at 48 {
> > + compatible = "ti,tsc2007";
> > + reg = <0x48>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <0x2 0x8>;
> > + gpios = <&gpio3 2 1>;
> as explain on the binding drop this gpios this is an IRQ not a gpio
>
> NACK
>
please read the tsc2007's code, in the patch there is :
+static int tsc2007_get_pendown_state_dt(struct tsc2007 *ts)
+{
+ return !gpio_get_value(ts->gpio);
+}
+
http://www.mail-archive.com/linux-input at vger.kernel.org/msg06765.html
Eric
next prev parent reply other threads:[~2013-11-21 8:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 13:17 [PATCHv9][ 1/3] Input: tsc2007: Add device tree support Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-08 13:17 ` [PATCHv9][ 2/3] ARM: dts: cpuimx51 Add touchscreen support Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-21 5:10 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:10 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:10 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-08 13:17 ` [PATCHv9][ 3/3] ARM: dts: cpuimx35 " Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-08 13:17 ` Denis Carikli
2013-11-21 5:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 8:00 ` Lothar Waßmann
2013-11-21 8:00 ` Lothar Waßmann
2013-11-21 8:00 ` Lothar Waßmann
2013-11-21 8:05 ` Eric Bénard [this message]
2013-11-21 8:05 ` Eric Bénard
2013-11-21 8:05 ` Eric Bénard
2013-11-19 21:11 ` [PATCHv9][ 1/3] Input: tsc2007: Add device tree support Dmitry Torokhov
2013-11-19 21:11 ` Dmitry Torokhov
2013-11-19 21:11 ` Dmitry Torokhov
2013-11-25 8:39 ` Denis Carikli
2013-11-25 8:39 ` Denis Carikli
2013-11-25 8:39 ` Denis Carikli
2013-11-21 5:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 5:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 8:03 ` Eric Bénard
2013-11-21 8:03 ` Eric Bénard
2013-11-21 8:03 ` Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121090528.41af72bd@e6520eb \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.