Re: [PATCH 7/7] packagegroup-arago-tisdk-matrix: Add additional example application for AM43x

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Nov 21, 2013 at 07:46:41AM -0500, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Wednesday, November 20, 2013 10:55 PM
> > To: Cooper Jr., Franklin
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 7/7] packagegroup-arago-tisdk-matrix: Add
> > additional example application for AM43x
> > 
> > On Tue, Nov 19, 2013 at 01:02:08PM -0600, Franklin S. Cooper Jr wrote:
> > > * Add additional example applications for AM43x.
> > >
> > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > ---
> > >  .../packagegroup-arago-tisdk-matrix.bb             |    8 +++++++-
> > >  1 files changed, 7 insertions(+), 1 deletions(-)
> > >
> > > diff --git
> > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > > k-matrix.bb
> > > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > > k-matrix.bb
> > > index 95054b2..c3143d3 100644
> > > ---
> > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > > k-matrix.bb
> > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > +++ tisdk-matrix.bb
> > > @@ -1,6 +1,6 @@
> > >  DESCRIPTION = "Task to include Matrix v2"
> > >  LICENSE = "MIT"
> > > -PR = "r22"
> > > +PR = "r23"
> > >
> > >  inherit packagegroup
> > >
> > > @@ -72,10 +72,16 @@ MATRIX_APPS_append_ti33x = "        \
> > >  #    matrix-gui-wifi-direct-demo
> > >
> > >  MATRIX_APPS_append_ti43x = "        \
> > > +
> > > +
> > ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d
> > > + )} \
> > 
> > So, I just noticed, that in patch #3 of this series, you add SGX libgles
> > unconditionally, but here you do check for the proper MACHINE_FEATURE...
> > 
> > Should it be one way or another? If you update patch #3 with conditional like
> > here, the whole series can be pushed even prior to the new SGX in meta-ti...

> [Franklin] The changes in patch three simply mimics what we have always been 
> doing right or wrong for other devices. Since the entire recipe is specific 
> to sgx we move the conditional check to the packagegroup/image that these 
> recipes are included in. Packagegroup-arago-toolchain-tisdk-target includes 
> packagegroup-arago-tisdk-graphics conditional based on MACHINE_FEATURE. 
> Likewise tisdk-rootfs-image includes packagegroup-arago-tisdk-graphics 
> conditional based on MACHINE_FEATURE.
> 
> As is it should still be fine but you still want it changed I can but I 
> should make the change for all the machines as well.

Ah, good point. If the checks are made outside in higher-level packagegroups, 
then it's fine with me and I'll try to push the patches after verifying that...


> > >      matrix-multimedia-demo-aac      \
> > >      matrix-multimedia-demo-h264dec  \
> > >      matrix-multimedia-demo-mpeg4aacdec \
> > >      matrix-multimedia-demo-mpeg4dec \
> > > +                                    \
> > > +    matrix-gui-generic-pm           \
> > > +    matrix-gui-pm-demos-suspend     \
> > > +    matrix-gui-clocks               \
> > >  "
> > >
> > >  MATRIX_APPS_append_omap-a15 = "     \
> > > --
> > > 1.7.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago