From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: thierry.reding@gmail.com, shawn.guo@linaro.org,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] backlight: pwm_bl: Do not make the regulator mandatory
Date: Fri, 22 Nov 2013 01:42:22 +0100 [thread overview]
Message-ID: <201311220142.22605.marex@denx.de> (raw)
In-Reply-To: <1385055795-24002-1-git-send-email-fabio.estevam@freescale.com>
Dear Fabio Estevam,
> Commit 22ceeee1 (pwm-backlight: Add power supply support) caused breakage
> on boards that do not define the backlight regulator on their dts files.
>
> Instead of making the backlight regulator mandatory, treat it as optional
> instead, so that we do not have breakage.
>
> This avoids the need for adding a dummy regulator on every dts file that
> uses the pwm-backlight.
>
> Tested on a mx6qsabresd.
This patch certainly makes sense, there are plenty of simple boards that have no
actual supply for the PWM.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] backlight: pwm_bl: Do not make the regulator mandatory
Date: Fri, 22 Nov 2013 01:42:22 +0100 [thread overview]
Message-ID: <201311220142.22605.marex@denx.de> (raw)
In-Reply-To: <1385055795-24002-1-git-send-email-fabio.estevam@freescale.com>
Dear Fabio Estevam,
> Commit 22ceeee1 (pwm-backlight: Add power supply support) caused breakage
> on boards that do not define the backlight regulator on their dts files.
>
> Instead of making the backlight regulator mandatory, treat it as optional
> instead, so that we do not have breakage.
>
> This avoids the need for adding a dummy regulator on every dts file that
> uses the pwm-backlight.
>
> Tested on a mx6qsabresd.
This patch certainly makes sense, there are plenty of simple boards that have no
actual supply for the PWM.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-22 0:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 17:43 [PATCH] backlight: pwm_bl: Do not make the regulator mandatory Fabio Estevam
2013-11-21 17:43 ` Fabio Estevam
2013-11-22 0:42 ` Marek Vasut [this message]
2013-11-22 0:42 ` Marek Vasut
2013-11-22 14:22 ` Thierry Reding
2013-11-22 14:22 ` Thierry Reding
2013-11-22 14:52 ` Mark Brown
2013-11-22 14:52 ` Mark Brown
2013-11-22 16:06 ` Fabio Estevam
2013-11-22 16:06 ` Fabio Estevam
2013-11-25 3:10 ` Shawn Guo
2013-11-25 3:10 ` Shawn Guo
2013-11-25 13:26 ` Fabio Estevam
2013-11-25 13:26 ` Fabio Estevam
2013-11-25 13:37 ` Shawn Guo
2013-11-25 13:37 ` Shawn Guo
2013-11-25 14:43 ` Fabio Estevam
2013-11-25 14:43 ` Fabio Estevam
2013-11-25 17:29 ` Mark Brown
2013-11-25 17:29 ` Mark Brown
2013-11-25 20:37 ` Fabio Estevam
2013-11-25 20:37 ` Fabio Estevam
2013-11-25 20:58 ` Fabio Estevam
2013-11-25 20:58 ` Fabio Estevam
2013-11-26 13:18 ` Mark Brown
2013-11-26 13:18 ` Mark Brown
2013-11-25 15:37 ` Mark Brown
2013-11-25 15:37 ` Mark Brown
2013-11-25 15:48 ` Mark Brown
2013-11-25 15:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311220142.22605.marex@denx.de \
--to=marex@denx.de \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.