From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core
Date: Fri, 22 Nov 2013 10:07:57 +0000 [thread overview]
Message-ID: <20131122100757.GI23067@lee--X1> (raw)
In-Reply-To: <1385114292.29083.8.camel@AMDC1943>
> > > +static struct mfd_cell max14577_devs[] = {
> > > + { .name = "max14577-muic", },
> > > + { .name = "max14577-regulator", },
> > > + { .name = "max14577-charger", },
> > > +};
> >
> > If these all support device tree, shouldn't you be populating
> > max14577_devs[x].of_compatible too? That way the MFD core will
> > automatically setup your dev.of_node pointers for you?
>
> Only the regulator driver uses bindings from DT and it searches for
> "regulators" node in parent's node:
> np = of_get_child_by_name(max14577->dev->of_node, "regulators");
> I can add of_compatible but I think this won't be reflected in actual
> DTS.
Well it should be. I'll reply to the other patch too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core
Date: Fri, 22 Nov 2013 10:07:57 +0000 [thread overview]
Message-ID: <20131122100757.GI23067@lee--X1> (raw)
In-Reply-To: <1385114292.29083.8.camel@AMDC1943>
> > > +static struct mfd_cell max14577_devs[] = {
> > > + { .name = "max14577-muic", },
> > > + { .name = "max14577-regulator", },
> > > + { .name = "max14577-charger", },
> > > +};
> >
> > If these all support device tree, shouldn't you be populating
> > max14577_devs[x].of_compatible too? That way the MFD core will
> > automatically setup your dev.of_node pointers for you?
>
> Only the regulator driver uses bindings from DT and it searches for
> "regulators" node in parent's node:
> np = of_get_child_by_name(max14577->dev->of_node, "regulators");
> I can add of_compatible but I think this won't be reflected in actual
> DTS.
Well it should be. I'll reply to the other patch too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-22 10:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 8:46 [PATCH v3 0/5] mfd: max14577: Add max14577 MFD drivers Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
2013-11-22 8:46 ` [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
2013-11-22 9:31 ` Lee Jones
2013-11-22 9:31 ` Lee Jones
2013-11-22 9:58 ` Krzysztof Kozlowski
2013-11-22 9:58 ` Krzysztof Kozlowski
2013-11-22 10:07 ` Lee Jones [this message]
2013-11-22 10:07 ` Lee Jones
2013-11-22 10:36 ` Mark Brown
2013-11-22 10:36 ` Mark Brown
2013-11-22 8:46 ` [PATCH v3 2/5] extcon: max14577: Add extcon-max14577 driver to support MUIC device Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
2013-11-22 10:35 ` Mark Brown
2013-11-22 10:35 ` Mark Brown
2013-11-22 11:34 ` Krzysztof Kozlowski
2013-11-22 11:34 ` Krzysztof Kozlowski
2013-11-22 8:46 ` [PATCH v3 3/5] charger: max14577: Add charger support for Maxim 14577 Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
2013-11-22 8:54 ` Alexander Shiyan
2013-11-22 8:54 ` Alexander Shiyan
2013-11-22 9:57 ` Krzysztof Kozlowski
2013-11-22 9:57 ` Krzysztof Kozlowski
2013-11-22 8:46 ` [PATCH v3 4/5] regulator: max14577: Add regulator driver " Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
2013-11-22 9:16 ` Lee Jones
2013-11-22 9:16 ` Lee Jones
2013-11-22 9:23 ` Krzysztof Kozlowski
2013-11-22 9:23 ` Krzysztof Kozlowski
2013-11-22 10:15 ` Lee Jones
2013-11-22 10:15 ` Lee Jones
2013-11-22 15:55 ` Krzysztof Kozlowski
2013-11-22 15:55 ` Krzysztof Kozlowski
2013-11-22 13:00 ` Bartlomiej Zolnierkiewicz
2013-11-22 13:00 ` Bartlomiej Zolnierkiewicz
2013-11-22 8:46 ` [PATCH v3 5/5] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2013-11-22 8:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122100757.GI23067@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.