From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
Date: Fri, 22 Nov 2013 07:17:35 -0800 [thread overview]
Message-ID: <20131122151735.GA2405@infradead.org> (raw)
In-Reply-To: <528F743D.9010800@oracle.com>
On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
> To remain the current semantics under the debug mode, this fix add
> an additional judgement to make this assertion only works for non-CRC
> enabled version.
> if (!gid_eq(igid, gid)) {
> if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
> - ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#ifdef DEBUG
> + if (!xfs_sb_version_has_pquotino(&mp->m_sb))
> + ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#endif
> ASSERT(mask & ATTR_GID);
> ASSERT(gdqp);
I'd just kill this assert. And it would be good to get some coverage
of running with all three quotas types into xfstests by default..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-22 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 15:11 [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize Jeff Liu
2013-11-22 15:17 ` Christoph Hellwig [this message]
2013-11-22 15:34 ` Jeff Liu
2013-11-22 15:38 ` Christoph Hellwig
2013-11-22 15:56 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122151735.GA2405@infradead.org \
--to=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.