Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize

From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
Date: Fri, 22 Nov 2013 23:34:07 +0800	[thread overview]
Message-ID: <528F796F.6070601@oracle.com> (raw)
In-Reply-To: <20131122151735.GA2405@infradead.org>

On 11/22 2013  23:17 PM, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
>> To remain the current semantics under the debug mode, this fix add
>> an additional judgement to make this assertion only works for non-CRC
>> enabled version.
> 
>>  		if (!gid_eq(igid, gid)) {
>>  			if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
>> -				ASSERT(!XFS_IS_PQUOTA_ON(mp));
>> +#ifdef DEBUG quota
>> +				if (!xfs_sb_version_has_pquotino(&mp->m_sb))
>> +					ASSERT(!XFS_IS_PQUOTA_ON(mp));
>> +#endif
>>  				ASSERT(mask & ATTR_GID);
>>  				ASSERT(gdqp);
> 
> I'd just kill this assert.
I hesitated about killing this assertion or hold the line before, will fix it soon.
> And it would be good to get some coverage
> of running with all three quotas types into xfstests by default..
Definitely!  I just found another race problem between dquot attach and quota off via
fsstress as per Dave's suggestion for another fix. :)

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs