All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Alex Thorlton <athorlton@sgi.com>
Cc: Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: BUG: mm, numa: test segfaults, only when NUMA balancing is on
Date: Sat, 23 Nov 2013 00:09:24 +0000	[thread overview]
Message-ID: <20131123000924.GC5285@suse.de> (raw)
In-Reply-To: <20131122230524.GB5285@suse.de>

On Fri, Nov 22, 2013 at 11:05:24PM +0000, Mel Gorman wrote:
> On Fri, Nov 22, 2013 at 03:28:07PM -0600, Alex Thorlton wrote:
> > > If the warning added by that patch does *not* trigger than can you also
> > > test this patch? It removes the barriers which should not be necessary
> > > and takes a reference tot he page before waiting on the lock. The
> > > previous version did not take the reference because otherwise the
> > > WARN_ON could not distinguish between a migration waiter and a surprise
> > > gup.
> > 
> > Sorry for the delay; been a bit busy.  I tested both of these patches on
> > top of this one (separately, of course):
> > 
> > http://www.spinics.net/lists/linux-mm/msg63919.html
> > 
> > I think that's the one you were referring to, if not send me a pointer
> > to the correct one and I'll give it another shot.  Both patches still
> > segfaulted, so it doesn't appear that either of these solved the
> > problem. 
> 
> I see. Does THP have to be enabled or does it segfault even with THP
> disabled?
> 

On a semi-related note, is the large machine doing anything with xpmem
or anything that depends on MMU notifiers to work properly? I noted
while looking at this that THP migration is not invalidating pages which
might be confusing a driver depending on it.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Alex Thorlton <athorlton@sgi.com>
Cc: Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: BUG: mm, numa: test segfaults, only when NUMA balancing is on
Date: Sat, 23 Nov 2013 00:09:24 +0000	[thread overview]
Message-ID: <20131123000924.GC5285@suse.de> (raw)
In-Reply-To: <20131122230524.GB5285@suse.de>

On Fri, Nov 22, 2013 at 11:05:24PM +0000, Mel Gorman wrote:
> On Fri, Nov 22, 2013 at 03:28:07PM -0600, Alex Thorlton wrote:
> > > If the warning added by that patch does *not* trigger than can you also
> > > test this patch? It removes the barriers which should not be necessary
> > > and takes a reference tot he page before waiting on the lock. The
> > > previous version did not take the reference because otherwise the
> > > WARN_ON could not distinguish between a migration waiter and a surprise
> > > gup.
> > 
> > Sorry for the delay; been a bit busy.  I tested both of these patches on
> > top of this one (separately, of course):
> > 
> > http://www.spinics.net/lists/linux-mm/msg63919.html
> > 
> > I think that's the one you were referring to, if not send me a pointer
> > to the correct one and I'll give it another shot.  Both patches still
> > segfaulted, so it doesn't appear that either of these solved the
> > problem. 
> 
> I see. Does THP have to be enabled or does it segfault even with THP
> disabled?
> 

On a semi-related note, is the large machine doing anything with xpmem
or anything that depends on MMU notifiers to work properly? I noted
while looking at this that THP migration is not invalidating pages which
might be confusing a driver depending on it.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2013-11-23  0:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 15:54 BUG: mm, numa: test segfaults, only when NUMA balancing is on Alex Thorlton
2013-10-16 15:54 ` Alex Thorlton
2013-10-17 11:30 ` Bob Liu
2013-10-17 11:30   ` Bob Liu
2013-10-18  0:33   ` Alex Thorlton
2013-10-18  0:33     ` Alex Thorlton
2013-11-04 14:58 ` Mel Gorman
2013-11-04 14:58   ` Mel Gorman
2013-11-04 20:03   ` Alex Thorlton
2013-11-04 20:03     ` Alex Thorlton
2013-11-06 13:10     ` Mel Gorman
2013-11-06 13:10       ` Mel Gorman
2013-11-07 21:48       ` Alex Thorlton
2013-11-07 21:48         ` Alex Thorlton
2013-11-08 11:20         ` Mel Gorman
2013-11-08 11:20           ` Mel Gorman
2013-11-08 14:08           ` Mel Gorman
2013-11-08 14:08             ` Mel Gorman
2013-11-08 22:13           ` Alex Thorlton
2013-11-08 22:13             ` Alex Thorlton
2013-11-12 21:29             ` Alex Thorlton
2013-11-12 21:29               ` Alex Thorlton
2013-11-15  0:09               ` Mel Gorman
2013-11-15  0:09                 ` Mel Gorman
2013-11-15 14:45                 ` Mel Gorman
2013-11-15 14:45                   ` Mel Gorman
2013-11-22 21:28                   ` Alex Thorlton
2013-11-22 21:28                     ` Alex Thorlton
2013-11-22 23:05                     ` Mel Gorman
2013-11-22 23:05                       ` Mel Gorman
2013-11-23  0:09                       ` Mel Gorman [this message]
2013-11-23  0:09                         ` Mel Gorman
2013-11-27 23:58                         ` Alex Thorlton
2013-11-27 23:58                           ` Alex Thorlton
2013-11-07 21:52 ` Alex Thorlton
2013-11-07 21:52   ` Alex Thorlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131123000924.GC5285@suse.de \
    --to=mgorman@suse.de \
    --cc=athorlton@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.