From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts
Date: Fri, 22 Nov 2013 17:15:16 -0800 [thread overview]
Message-ID: <20131123011515.GO10023@atomide.com> (raw)
In-Reply-To: <20131123010850.GN10023@atomide.com>
* Tony Lindgren <tony@atomide.com> [131122 17:09]:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [131122 16:56]:
> > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote:
> > > + /* See of_device_resource_notify for populating interrupts */
> > > + for (i = 0; i < num_irq; i++, res++) {
> > > + res->flags = IORESOURCE_IRQ;
> > > + res->start = -EPROBE_DEFER;
> > > + res->end = -EPROBE_DEFER;
> >
> > NAK. Definitely a bad idea to start introducing magic values other into
> > resources. Please don't do this.
>
> Do you have any better ideas on how to sort out this issue then?
I guess we could allocate all the resources lazily here, I'll take a look
at that.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts
Date: Fri, 22 Nov 2013 17:15:16 -0800 [thread overview]
Message-ID: <20131123011515.GO10023@atomide.com> (raw)
In-Reply-To: <20131123010850.GN10023@atomide.com>
* Tony Lindgren <tony@atomide.com> [131122 17:09]:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [131122 16:56]:
> > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote:
> > > + /* See of_device_resource_notify for populating interrupts */
> > > + for (i = 0; i < num_irq; i++, res++) {
> > > + res->flags = IORESOURCE_IRQ;
> > > + res->start = -EPROBE_DEFER;
> > > + res->end = -EPROBE_DEFER;
> >
> > NAK. Definitely a bad idea to start introducing magic values other into
> > resources. Please don't do this.
>
> Do you have any better ideas on how to sort out this issue then?
I guess we could allocate all the resources lazily here, I'll take a look
at that.
Tony
next prev parent reply other threads:[~2013-11-23 1:15 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 0:43 [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Tony Lindgren
2013-11-23 0:43 ` Tony Lindgren
2013-11-23 0:43 ` Tony Lindgren
2013-11-23 0:55 ` Russell King - ARM Linux
2013-11-23 0:55 ` Russell King - ARM Linux
2013-11-23 0:55 ` Russell King - ARM Linux
2013-11-23 1:08 ` Tony Lindgren
2013-11-23 1:08 ` Tony Lindgren
2013-11-23 1:15 ` Tony Lindgren [this message]
2013-11-23 1:15 ` Tony Lindgren
2013-11-23 1:50 ` Tony Lindgren
2013-11-23 1:50 ` Tony Lindgren
2013-11-23 1:50 ` Tony Lindgren
2013-11-23 15:42 ` Rob Herring
2013-11-23 15:42 ` Rob Herring
2013-11-23 15:42 ` Rob Herring
2013-11-23 16:32 ` Tony Lindgren
2013-11-23 16:32 ` Tony Lindgren
2013-11-23 16:32 ` Tony Lindgren
2013-11-25 9:34 ` Thierry Reding
2013-11-25 9:34 ` Thierry Reding
2013-11-25 9:34 ` Thierry Reding
2013-11-25 19:46 ` Tony Lindgren
2013-11-25 19:46 ` Tony Lindgren
2013-11-25 19:46 ` Tony Lindgren
2013-11-24 21:27 ` Grant Likely
2013-11-24 21:27 ` Grant Likely
2013-12-10 3:39 ` Paul Walmsley
2013-12-10 3:39 ` Paul Walmsley
2013-12-30 22:10 ` Paul Walmsley
2013-12-30 22:10 ` Paul Walmsley
2013-12-30 22:10 ` Paul Walmsley
[not found] ` <alpine.DEB.2.02.1312302209200.8869-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2013-12-31 16:33 ` Rob Herring
2013-12-31 16:33 ` Rob Herring
2013-12-31 16:33 ` Rob Herring
2014-01-06 23:41 ` Paul Walmsley
2014-01-06 23:41 ` Paul Walmsley
2014-01-08 1:19 ` Tony Lindgren
2014-01-08 1:19 ` Tony Lindgren
2014-01-08 12:51 ` [PATCH] driver-core: platform: Resolve DT interrupt references late Thierry Reding
2014-01-08 12:51 ` Thierry Reding
2014-01-08 13:41 ` Arnd Bergmann
2014-01-08 13:41 ` Arnd Bergmann
2014-01-08 13:41 ` Arnd Bergmann
2014-01-08 14:55 ` Thierry Reding
2014-01-08 14:55 ` Thierry Reding
2014-01-08 15:11 ` Arnd Bergmann
2014-01-08 15:11 ` Arnd Bergmann
2014-01-08 15:58 ` Thierry Reding
2014-01-08 15:58 ` Thierry Reding
[not found] ` <20140108155855.GA22984-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-01-08 16:25 ` Arnd Bergmann
2014-01-08 16:25 ` Arnd Bergmann
2014-01-08 16:25 ` Arnd Bergmann
2014-01-08 19:59 ` Thierry Reding
2014-01-08 19:59 ` Thierry Reding
[not found] ` <20140108195909.GB1298-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-01-08 20:09 ` Arnd Bergmann
2014-01-08 20:09 ` Arnd Bergmann
2014-01-08 20:09 ` Arnd Bergmann
2014-01-08 20:24 ` Thierry Reding
2014-01-08 20:24 ` Thierry Reding
2014-01-08 21:01 ` Arnd Bergmann
2014-01-08 21:01 ` Arnd Bergmann
[not found] ` <1389185477-507-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-08 16:40 ` Tony Lindgren
2014-01-08 16:40 ` Tony Lindgren
2014-01-08 16:40 ` Tony Lindgren
[not found] ` <20140108164040.GA31686-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-01-08 19:28 ` Thierry Reding
2014-01-08 19:28 ` Thierry Reding
2014-01-08 19:28 ` Thierry Reding
2014-01-08 21:43 ` Tony Lindgren
2014-01-08 21:43 ` Tony Lindgren
2013-11-23 1:07 ` [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Tony Lindgren
2013-11-23 1:07 ` Tony Lindgren
2013-11-23 1:07 ` Tony Lindgren
2013-11-24 21:36 ` Grant Likely
2013-11-24 21:36 ` Grant Likely
2013-11-24 21:36 ` Grant Likely
2013-11-25 9:25 ` Thierry Reding
2013-11-25 9:25 ` Thierry Reding
2013-11-25 9:25 ` Thierry Reding
[not found] ` < 20131125094954.GF22043@ulmo.nvidia.com>
2013-11-25 9:49 ` Thierry Reding
2013-11-25 9:49 ` Thierry Reding
2013-11-25 9:49 ` Thierry Reding
2013-11-25 19:50 ` Tony Lindgren
2013-11-25 19:50 ` Tony Lindgren
2013-11-27 15:56 ` Grant Likely
2013-11-27 15:56 ` Grant Likely
2013-11-28 15:46 ` Thierry Reding
2013-11-28 15:46 ` Thierry Reding
2013-11-28 15:46 ` Thierry Reding
2013-12-11 13:45 ` Grant Likely
2013-12-11 13:45 ` Grant Likely
2013-12-11 15:12 ` Thierry Reding
2013-12-11 15:12 ` Thierry Reding
2013-12-11 15:12 ` Thierry Reding
2013-12-11 16:43 ` Tony Lindgren
2013-12-11 16:43 ` Tony Lindgren
2013-11-27 15:54 ` Grant Likely
2013-11-27 15:54 ` Grant Likely
2013-11-27 15:54 ` Grant Likely
2013-11-27 21:53 ` Tony Lindgren
2013-11-27 21:53 ` Tony Lindgren
2013-11-27 21:53 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2014-04-10 21:38 Tony Lindgren
2014-04-11 0:29 ` Rob Herring
2014-04-11 18:43 ` Thierry Reding
2014-04-18 20:55 ` Tony Lindgren
2014-04-11 9:20 ` Russell King - ARM Linux
2014-04-11 18:36 ` Thierry Reding
2014-04-18 21:37 ` Tony Lindgren
2014-04-18 23:18 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123011515.GO10023@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.