From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/5] ARM: brcmstb: add misc. DT bindings for brcm, brcmstb
Date: Sat, 23 Nov 2013 19:37:37 +0100 [thread overview]
Message-ID: <201311231937.38235.arnd@arndb.de> (raw)
In-Reply-To: <529003BB.9030604@gmail.com>
On Saturday 23 November 2013, Marc C wrote:
> +This node describes the register block which is used for generic reset control.
> +
> + - compatible: "brcm,brcmstb-sun-top-ctrl"
> + - properties:
> + o reg = <base_of_sun_top_ctrl_regs length>;
> + o reset-source-enable-reg = <offset_from_base>;
> + o sw-master-reset-reg = <offset_from_base>;
Normally the "compatible" string identifies the register layout and you keep the
offsets in the device driver. Do you have strong reasons to do it differently
here?
I would also suggest moving this block into a separate file for the reset
controller. Make sure you follow the rules from
Documentation/devicetree/bindings/reset/reset.txt, most importantly adding
a "#reset-cells" property so other drivers can refer to this node using
the reset API.
Arnd
next prev parent reply other threads:[~2013-11-23 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 1:24 [PATCH RESEND 3/5] ARM: brcmstb: add misc. DT bindings for brcm, brcmstb Marc C
2013-11-23 18:37 ` Arnd Bergmann [this message]
2013-11-23 20:11 ` Marc C
2013-11-23 20:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311231937.38235.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.