All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/5] ARM: brcmstb: add misc. DT bindings for brcm, brcmstb
Date: Sat, 23 Nov 2013 21:45:29 +0100	[thread overview]
Message-ID: <201311232145.30203.arnd@arndb.de> (raw)
In-Reply-To: <52910BFD.2010900@gmail.com>

On Saturday 23 November 2013, Marc C wrote:
> Hello Arnd,
> 
> > Normally the "compatible" string identifies the register layout and
> > you keep the offsets in the device driver. Do you have strong reasons to do it
> > differently here?
> 
> The register block that contains the reset registers also contains other
> ?general purpose? registers, which can potentially scoot the positions
> of both ?sw-master-reset? and ?reset-source-enable?. Although we do
> stress to the H/W designers that consistency between chips is important,
> and that relative offsets of those registers should remain the same
> between chip revisions, there is no guarantee that this will happen.
> 
> Now, rather than handling N revisions of the ?sun-top-ctrl? register
> block at both the boot loader and kernel levels (N could get very large
> as we continue to port support for more chips), I feel that a more
> flexible solution would be to rely on the self-describing nature of the DT.

Ok, I see. I guess it's not even a uniform layout within the registers
then, right? Otherwise you could reference the number of the reset
register through the reset-api, but it gets kind of ugly when passing
the wrong value for a reset line touches a completely unrelated register
rather than "just" resetting the wrong device.

	Arnd

      reply	other threads:[~2013-11-23 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  1:24 [PATCH RESEND 3/5] ARM: brcmstb: add misc. DT bindings for brcm, brcmstb Marc C
2013-11-23 18:37 ` Arnd Bergmann
2013-11-23 20:11   ` Marc C
2013-11-23 20:45     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201311232145.30203.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.