From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space
Date: Sat, 23 Nov 2013 22:56:33 +0100 [thread overview]
Message-ID: <20131123215633.GL32202@zapo.xilinx.com> (raw)
In-Reply-To: <5290ED53.5020908@suse.de>
On Sat, Nov 23, 2013 at 07:00:51PM +0100, Andreas Färber wrote:
> Am 22.11.2013 17:02, schrieb Edgar E. Iglesias:
> > Hi, no I actually had it in cpustate first but had to do env-get-cpu all
> > over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck.
>
> No, it doesn't any more, it's just a pointer offset.
>
Hi Andreas,
Looking at todays master, for example for i386:
target-i386/cpu-qom.h:
#define ENV_GET_CPU(e) CPU(x86_env_get_cpu(e))
include/qom/cpu.h:
#define CPU(obj) OBJECT_CHECK(CPUState, (obj), TYPE_CPU)
include/qom/object.h:
#define OBJECT_CHECK(type, obj, name) \
((type *)object_dynamic_cast_assert(OBJECT(obj), (name), \
__FILE__, __LINE__, __func__))
Maybe we should remove the CPU() around xx_env_get_cpu(e)?
I'm happy to move the cpu address space into CPUState, but right
now I'm afraid ENV_GET_CPU will slow down some of these hot paths.
Cheers,
Edgar
next prev parent reply other threads:[~2013-11-23 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 15:15 [Qemu-devel] [RFC PATCH 0/8] Steps towards per CPU address-spaces edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 1/8] exec: Make tb_invalidate_phys_addr input an AS edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 2/8] exec: Make iotlb_to_region " edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 3/8] exec: Always initialize MemorySection address spaces edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 4/8] exec: Make memory_region_section_get_iotlb use section AS edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 5/8] memory: Add MemoryListener to typedefs edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space edgar.iglesias
2013-11-22 15:50 ` Peter Maydell
2013-11-22 16:02 ` Edgar E. Iglesias
2013-11-23 18:00 ` Andreas Färber
2013-11-23 21:56 ` Edgar E. Iglesias [this message]
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 7/8] exec: On AS changes, only flush affected CPU TLBs edgar.iglesias
2013-11-22 15:15 ` [Qemu-devel] [RFC PATCH 8/8] exec: Make ldl_*_phys input an AddressSpace edgar.iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123215633.GL32202@zapo.xilinx.com \
--to=edgar.iglesias@gmail.com \
--cc=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.