Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

["Andreas Färber" <afaerber@suse.de>]

Am 22.11.2013 17:02, schrieb Edgar E. Iglesias:
> Hi, no I actually had it in cpustate first but had to do env-get-cpu all
> over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck.

No, it doesn't any more, it's just a pointer offset.

Andreas

> I havent meassured the perf impact though.
> 
> Sorry for phone email...
> 
> Cheers
> 
> ---
> Sent from my phone
> 
> On Nov 22, 2013 4:51 PM, "Peter Maydell" <peter.maydell@linaro.org
> <mailto:peter.maydell@linaro.org>> wrote:
> 
>     On 22 November 2013 15:15,  <edgar.iglesias@gmail.com
>     <mailto:edgar.iglesias@gmail.com>> wrote:
>     > @@ -176,6 +176,9 @@ typedef struct CPUWatchpoint {
>     >      sigjmp_buf jmp_env;                                          
>           \
>     >      int exception_index;                                        
>            \
>     >                                                                  
>            \
>     > +    /* Per CPU address-space.  */                                
>           \
>     > +    AddressSpace *as;                                            
>           \
>     > +                                                                
>            \
> 
>     Does this really have to live in the env struct rather than
>     CPUState ?
> 
>     thanks
>     -- PMM
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg