From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Explicitly check for linking format to use for efiemu64 module
Date: Mon, 25 Nov 2013 21:42:20 +0400 [thread overview]
Message-ID: <20131125214220.68453de4@opensuse.site> (raw)
In-Reply-To: <5292D0A2.8040301@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
В Mon, 25 Nov 2013 05:22:58 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> > + CFLAGS="-m64 -nostdlib -O2 -mcmodel=large -mno-red-zone"
> > + LDFLAGS="-m64 -Wl,$format -nostdlib"
> You need -static as otherwise on Apple systems it will try to pull in
> the dynamic linker which we don't want (scratch comment about other
> thread, I though of adding -static everywhere but it's no necessarry
> after all)
I used the same flags as in Makefile. If -static is needed here should
not it be added to grub-core/Makefile.am as well?
> > diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
> > index e2da083..e6862b7 100644
> > --- a/grub-core/Makefile.am
> > +++ b/grub-core/Makefile.am
> > @@ -421,7 +421,7 @@ efiemu64.o: efiemu64_c.o efiemu64_s.o $(TARGET_OBJ2ELEF)
> > $(TARGET_OBJCONV) -felf64 -nu -nd $@.bin $@ || exit 1; \
> > rm -f $@.bin; \
> Here the check for apple linker has to be adjusted as
> x$(EFIEMU64_LINK_FORMAT) = x-arch,x86_64
Mmm ... but I assume apple linker case *did* work before and it broke
only for the case !TARGET_APPLE_LINKER. Should $(EFIEMU64_LINK_FORMAT)
be added for apple linker case as well? I have no way to test it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-11-25 17:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 9:14 grub2 boot root-on-zfs errors Beeblebrox
2013-11-24 15:08 ` Andrey Borzenkov
2013-11-25 11:08 ` Beeblebrox
2013-11-25 11:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-25 17:29 ` Andrey Borzenkov
2013-11-25 22:12 ` Vladimir 'phcoder' Serbinenko
2013-11-24 17:21 ` [PATCH] Explicitly check for linking format to use for efiemu64 module Andrey Borzenkov
2013-11-25 3:59 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-25 4:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-25 17:42 ` Andrey Borzenkov [this message]
2013-11-25 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-25 18:13 ` [PATCH v2] " Andrey Borzenkov
2013-11-25 18:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-25 18:34 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125214220.68453de4@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.