[PATCH] perf tools: Fix tags target rebuilding

[PATCH] perf tools: Fix tags target rebuilding

[Jiri Olsa]

Once the tags file is generated it's never rebuilt
until it's removed by hand.

The reason is that the Makefile does not treat tags
as a target but as a file to be rebuilt.

Adding tags as PHONY target into the Makefile.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..95f5792 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -61,7 +61,7 @@ endef
 #
 # Needed if no target specified:
 #
-all:
+all tags:
 	$(print_msg)
 	$(make)
 
@@ -77,3 +77,5 @@ clean:
 %:
 	$(print_msg)
 	$(make)
+
+.PHONY: tags
-- 
1.8.3.1

Re: [PATCH] perf tools: Fix tags target rebuilding

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> Once the tags file is generated it's never rebuilt
> until it's removed by hand.
> 
> The reason is that the Makefile does not treat tags
> as a target but as a file to be rebuilt.
> 
> Adding tags as PHONY target into the Makefile.
> 
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 4835618..95f5792 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -61,7 +61,7 @@ endef
>  #
>  # Needed if no target specified:
>  #
> -all:
> +all tags:

Obviously the change invalidates the comment above.

>  	$(print_msg)
>  	$(make)
>  
> @@ -77,3 +77,5 @@ clean:
>  %:
>  	$(print_msg)
>  	$(make)
> +
> +.PHONY: tags

Note that there's also a TAGS file that uses etags - which probably 
needs similar treatment.

Also note that we have duplicate code for this in Makefile.perf 
already. Would it be possible to pass through this there and keep the 
main Makefile is just a thin, minimal wrapper that adds default 
parallelism, etc?

Thanks,

	Ingo

Re: [PATCH] perf tools: Fix tags target rebuilding

[Jiri Olsa]

On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > Once the tags file is generated it's never rebuilt
> > until it's removed by hand.
> > 
> > The reason is that the Makefile does not treat tags
> > as a target but as a file to be rebuilt.
> > 
> > Adding tags as PHONY target into the Makefile.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Mike Galbraith <efault@gmx.de>
> > Cc: Stephane Eranian <eranian@google.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> >  tools/perf/Makefile | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > index 4835618..95f5792 100644
> > --- a/tools/perf/Makefile
> > +++ b/tools/perf/Makefile
> > @@ -61,7 +61,7 @@ endef
> >  #
> >  # Needed if no target specified:
> >  #
> > -all:
> > +all tags:
> 
> Obviously the change invalidates the comment above.

ugh, haven't noticed that comment ;-)

> 
> >  	$(print_msg)
> >  	$(make)
> >  
> > @@ -77,3 +77,5 @@ clean:
> >  %:
> >  	$(print_msg)
> >  	$(make)
> > +
> > +.PHONY: tags
> 
> Note that there's also a TAGS file that uses etags - which probably 
> needs similar treatment.

yes

> 
> Also note that we have duplicate code for this in Makefile.perf 
> already. Would it be possible to pass through this there and keep the 
> main Makefile is just a thin, minimal wrapper that adds default 
> parallelism, etc?

well, thats what I actually tried to do.. pass the
processing to the Makefile.perf otherwise it stops
in Makefile

I guess you want some generic way of doing that

jirka

Re: [PATCH] perf tools: Fix tags target rebuilding

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > Once the tags file is generated it's never rebuilt
> > > until it's removed by hand.
> > > 
> > > The reason is that the Makefile does not treat tags
> > > as a target but as a file to be rebuilt.
> > > 
> > > Adding tags as PHONY target into the Makefile.
> > > 
> > > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > > Cc: Ingo Molnar <mingo@kernel.org>
> > > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Mike Galbraith <efault@gmx.de>
> > > Cc: Stephane Eranian <eranian@google.com>
> > > Cc: David Ahern <dsahern@gmail.com>
> > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > ---
> > >  tools/perf/Makefile | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > > index 4835618..95f5792 100644
> > > --- a/tools/perf/Makefile
> > > +++ b/tools/perf/Makefile
> > > @@ -61,7 +61,7 @@ endef
> > >  #
> > >  # Needed if no target specified:
> > >  #
> > > -all:
> > > +all tags:
> > 
> > Obviously the change invalidates the comment above.
> 
> ugh, haven't noticed that comment ;-)
> 
> > 
> > >  	$(print_msg)
> > >  	$(make)
> > >  
> > > @@ -77,3 +77,5 @@ clean:
> > >  %:
> > >  	$(print_msg)
> > >  	$(make)
> > > +
> > > +.PHONY: tags
> > 
> > Note that there's also a TAGS file that uses etags - which probably 
> > needs similar treatment.
> 
> yes
> 
> > 
> > Also note that we have duplicate code for this in Makefile.perf 
> > already. Would it be possible to pass through this there and keep the 
> > main Makefile is just a thin, minimal wrapper that adds default 
> > parallelism, etc?
> 
> well, thats what I actually tried to do.. pass the
> processing to the Makefile.perf otherwise it stops
> in Makefile
> 
> I guess you want some generic way of doing that

If it's just these two phony targets that need to be in the main 
makefile then I guess your approach is the simplest one and we should 
do it like that instead of complicating the interface. If it gets 
messier in the future we can reconsider?

Thanks,

	Ingo

[PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

[Jiri Olsa]

On Tue, Nov 26, 2013 at 01:00:55PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:

SNIP

> > > 
> > > Also note that we have duplicate code for this in Makefile.perf 
> > > already. Would it be possible to pass through this there and keep the 
> > > main Makefile is just a thin, minimal wrapper that adds default 
> > > parallelism, etc?
> > 
> > well, thats what I actually tried to do.. pass the
> > processing to the Makefile.perf otherwise it stops
> > in Makefile
> > 
> > I guess you want some generic way of doing that
> 
> If it's just these two phony targets that need to be in the main 
> makefile then I guess your approach is the simplest one and we should 
> do it like that instead of complicating the interface. If it gets 
> messier in the future we can reconsider?
> 

sounds good, pelase check v2

thanks,
jirka


---
Once the tags/TAGS file is generated it's never rebuilt
until it's removed by hand.

The reason is that the Makefile does not treat tags/TAGS
as targets but as files and thus won't rebuilt them
once they are in place.

Adding PHONY tags/TAGS targets into Makefile.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..eefb9fb 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -60,8 +60,11 @@ endef
 
 #
 # Needed if no target specified:
+# (Except for tags and TAGS targets. The reason is that the
+# Makefile does not treat tags/TAGS as targets but as files
+# and thus won't rebuilt them once they are in place.)
 #
-all:
+all tags TAGS:
	$(print_msg)
	$(make)
 
@@ -77,3 +80,5 @@ clean:
 %:
	$(print_msg)
	$(make)
+
+.PHONY: tags TAGS
-- 
1.8.3.1

Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Nov 26, 2013 at 01:00:55PM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:
> 
> SNIP
> 
> > > > 
> > > > Also note that we have duplicate code for this in Makefile.perf 
> > > > already. Would it be possible to pass through this there and keep the 
> > > > main Makefile is just a thin, minimal wrapper that adds default 
> > > > parallelism, etc?
> > > 
> > > well, thats what I actually tried to do.. pass the
> > > processing to the Makefile.perf otherwise it stops
> > > in Makefile
> > > 
> > > I guess you want some generic way of doing that
> > 
> > If it's just these two phony targets that need to be in the main 
> > makefile then I guess your approach is the simplest one and we should 
> > do it like that instead of complicating the interface. If it gets 
> > messier in the future we can reconsider?
> > 
> 
> sounds good, pelase check v2
> 
> thanks,
> jirka
> 
> 
> ---
> Once the tags/TAGS file is generated it's never rebuilt
> until it's removed by hand.
> 
> The reason is that the Makefile does not treat tags/TAGS
> as targets but as files and thus won't rebuilt them
> once they are in place.
> 
> Adding PHONY tags/TAGS targets into Makefile.
> 
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 4835618..eefb9fb 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -60,8 +60,11 @@ endef
>  
>  #
>  # Needed if no target specified:
> +# (Except for tags and TAGS targets. The reason is that the
> +# Makefile does not treat tags/TAGS as targets but as files
> +# and thus won't rebuilt them once they are in place.)

s/rebuilt/rebuild

Btw., could we perhaps change the targets to 'ctags' and 'etags' 
instead? (That will make it natural to add 'gtags' in the future, 
should anyone want that.)

Thanks,

	Ingo

Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

[Jiri Olsa]

On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:

SNIP

> >  
> >  #
> >  # Needed if no target specified:
> > +# (Except for tags and TAGS targets. The reason is that the
> > +# Makefile does not treat tags/TAGS as targets but as files
> > +# and thus won't rebuilt them once they are in place.)
> 
> s/rebuilt/rebuild
> 
> Btw., could we perhaps change the targets to 'ctags' and 'etags' 
> instead? (That will make it natural to add 'gtags' in the future, 
> should anyone want that.)

my fingers vote against removing 'make tags' (and cscope)
dont care much about the rest though.. ;-)

jirka

Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:
> 
> SNIP
> 
> > >  
> > >  #
> > >  # Needed if no target specified:
> > > +# (Except for tags and TAGS targets. The reason is that the
> > > +# Makefile does not treat tags/TAGS as targets but as files
> > > +# and thus won't rebuilt them once they are in place.)
> > 
> > s/rebuilt/rebuild
> > 
> > Btw., could we perhaps change the targets to 'ctags' and 'etags' 
> > instead? (That will make it natural to add 'gtags' in the future, 
> > should anyone want that.)
> 
> my fingers vote against removing 'make tags' (and cscope)
> dont care much about the rest though.. ;-)

Okay, fair enough, and 'tags/TAGS' targets is also what the main 
kernel build system uses - so I concur. For your updated v2 patch:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

[Arnaldo Carvalho de Melo]

Em Wed, Nov 27, 2013 at 12:16:50AM +0100, Jiri Olsa escreveu:
> On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:
> 
> SNIP
> 
> > >  
> > >  #
> > >  # Needed if no target specified:
> > > +# (Except for tags and TAGS targets. The reason is that the
> > > +# Makefile does not treat tags/TAGS as targets but as files
> > > +# and thus won't rebuilt them once they are in place.)
> > 
> > s/rebuilt/rebuild
> > 
> > Btw., could we perhaps change the targets to 'ctags' and 'etags' 
> > instead? (That will make it natural to add 'gtags' in the future, 
> > should anyone want that.)
> 
> my fingers vote against removing 'make tags' (and cscope)
> dont care much about the rest though.. ;-)

Ditto, please leave 'make tags', just like that kernel.

- Arnaldo

[tip:perf/core] perf tools: Fix tags/TAGS targets rebuilding

[tip-bot for Jiri Olsa]

Commit-ID:  26286141a43251bed548349efbf60b61f1c433e8
Gitweb:     http://git.kernel.org/tip/26286141a43251bed548349efbf60b61f1c433e8
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Tue, 26 Nov 2013 13:54:12 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 27 Nov 2013 16:47:14 -0300

perf tools: Fix tags/TAGS targets rebuilding

Once the tags/TAGS file is generated it's never rebuilt until it's
removed by hand.

The reason is that the Makefile does not treat tags/TAGS as targets but
as files and thus won't rebuilt them once they are in place.

Adding PHONY tags/TAGS targets into Makefile.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20131126125412.GJ1267@krava.brq.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..eefb9fb 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -60,8 +60,11 @@ endef
 
 #
 # Needed if no target specified:
+# (Except for tags and TAGS targets. The reason is that the
+# Makefile does not treat tags/TAGS as targets but as files
+# and thus won't rebuilt them once they are in place.)
 #
-all:
+all tags TAGS:
 	$(print_msg)
 	$(make)
 
@@ -77,3 +80,5 @@ clean:
 %:
 	$(print_msg)
 	$(make)
+
+.PHONY: tags TAGS