From: Lee Jones <lee.jones@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com,
sameo@linux.intel.com, dev@lynxeye.de, mark.rutland@arm.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mfd: tps6586x: add version detection
Date: Wed, 27 Nov 2013 15:30:19 +0000 [thread overview]
Message-ID: <20131127153019.GR3296@lee--X1> (raw)
In-Reply-To: <c26ecd550e9940ead950f3874d27a5b0@agner.ch>
On Wed, 27 Nov 2013, Stefan Agner wrote:
> Am 2013-11-27 15:36, schrieb Lee Jones:
> <snip>
> >> Perhaps I should suggest to make TPS6586X_ANY a positive number then,
> >> as a negative value to me indicates more of an error than a generic
> >> parameter.
> I see, its especially confusing since the version is filled using the
> i2c_smbus_read_byte_data functions return value. The version field is a
> 8-Bit value according to the data sheet, I could use 0x100 as
> TPS6586X_ANY identifier.
How far are we away from using 0xFF?
I'd be happy to use that and change it _if_ we ever get close.
If it's likely that it'll be used, then sure 0x100 sounds okay too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mfd: tps6586x: add version detection
Date: Wed, 27 Nov 2013 15:30:19 +0000 [thread overview]
Message-ID: <20131127153019.GR3296@lee--X1> (raw)
In-Reply-To: <c26ecd550e9940ead950f3874d27a5b0@agner.ch>
On Wed, 27 Nov 2013, Stefan Agner wrote:
> Am 2013-11-27 15:36, schrieb Lee Jones:
> <snip>
> >> Perhaps I should suggest to make TPS6586X_ANY a positive number then,
> >> as a negative value to me indicates more of an error than a generic
> >> parameter.
> I see, its especially confusing since the version is filled using the
> i2c_smbus_read_byte_data functions return value. The version field is a
> 8-Bit value according to the data sheet, I could use 0x100 as
> TPS6586X_ANY identifier.
How far are we away from using 0xFF?
I'd be happy to use that and change it _if_ we ever get close.
If it's likely that it'll be used, then sure 0x100 sounds okay too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-27 15:30 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 23:45 [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-26 23:45 ` [PATCH 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-27 13:09 ` Lee Jones
2013-11-27 13:09 ` Lee Jones
2013-11-27 13:11 ` Lee Jones
2013-11-27 13:11 ` Lee Jones
2013-11-27 13:49 ` Stefan Agner
2013-11-27 13:49 ` Stefan Agner
2013-11-27 13:49 ` Stefan Agner
[not found] ` <cd69295e946b48451f449eacc02efa4a-XLVq0VzYD2Y@public.gmane.org>
2013-11-27 13:55 ` Lee Jones
2013-11-27 13:55 ` Lee Jones
2013-11-27 13:55 ` Lee Jones
[not found] ` <cfb203a896eda67c106794d89e668d56@agner.ch>
[not found] ` <20131127143429.GN3296@lee--X1>
2013-11-27 14:36 ` Lee Jones
2013-11-27 14:36 ` Lee Jones
2013-11-27 14:36 ` Lee Jones
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:30 ` Lee Jones [this message]
2013-11-27 15:30 ` Lee Jones
2013-11-27 15:52 ` Stefan Agner
2013-11-27 15:52 ` Stefan Agner
2013-11-27 15:52 ` Stefan Agner
[not found] ` <89dbf704d8617c77259e04753e4380c9-XLVq0VzYD2Y@public.gmane.org>
2013-11-27 16:14 ` Lee Jones
2013-11-27 16:14 ` Lee Jones
2013-11-27 16:14 ` Lee Jones
[not found] ` <ef881d39f78b75b4badeebb5be0264edc3906d86.1385508112.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-11-27 16:58 ` Stephen Warren
2013-11-27 16:58 ` Stephen Warren
2013-11-27 16:58 ` Stephen Warren
[not found] ` <529624CA.6030604-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-27 21:44 ` Stefan Agner
2013-11-27 21:44 ` Stefan Agner
2013-11-27 21:44 ` Stefan Agner
2013-11-26 23:45 ` [PATCH 2/3] regulator: tps6586x: add voltage table for tps658643 Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-26 23:45 ` Stefan Agner
[not found] ` <8be2fe8560cc19f03d5be40ad3dc21d5979c8358.1385508112.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-11-27 17:09 ` Stephen Warren
2013-11-27 17:09 ` Stephen Warren
2013-11-27 17:09 ` Stephen Warren
[not found] ` <5296273C.1000705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-27 21:56 ` Stefan Agner
2013-11-27 21:56 ` Stefan Agner
2013-11-27 21:56 ` Stefan Agner
[not found] ` <93a0f4b1da2a54e58cee0756ab5f3e36-XLVq0VzYD2Y@public.gmane.org>
2013-11-28 8:30 ` Thierry Reding
2013-11-28 8:30 ` Thierry Reding
2013-11-28 8:30 ` Thierry Reding
2013-11-26 23:45 ` [PATCH 3/3] ARM: tegra: set SM2 voltage correct Stefan Agner
2013-11-26 23:45 ` Stefan Agner
2013-11-26 23:45 ` Stefan Agner
[not found] ` <c9ceead9e3df77b5a33ad654db23c241cd624096.1385508112.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-11-27 9:59 ` Lucas Stach
2013-11-27 9:59 ` Lucas Stach
2013-11-27 9:59 ` Lucas Stach
[not found] ` <1385546387.4270.11.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:06 ` Lucas Stach
2013-11-27 11:06 ` Lucas Stach
2013-11-27 17:13 ` Stephen Warren
2013-11-27 17:13 ` Stephen Warren
2013-11-27 17:13 ` Stephen Warren
[not found] ` <5296281C.1060403-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-27 22:03 ` Stefan Agner
2013-11-27 22:03 ` Stefan Agner
2013-11-27 22:03 ` Stefan Agner
2013-11-28 9:49 ` Lucas Stach
2013-11-28 9:49 ` Lucas Stach
2013-11-28 9:49 ` Lucas Stach
2013-11-30 16:24 ` Stefan Agner
2013-11-30 16:24 ` Stefan Agner
[not found] ` <cover.1385508112.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-11-28 8:13 ` [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Thierry Reding
2013-11-28 8:13 ` Thierry Reding
2013-11-28 8:13 ` Thierry Reding
2013-11-29 8:20 ` Kai Poggensee
2013-11-29 8:20 ` Kai Poggensee
2013-11-29 8:20 ` Kai Poggensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127153019.GR3296@lee--X1 \
--to=lee.jones@linaro.org \
--cc=dev@lynxeye.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.