From: Mark Brown <broonie@kernel.org>
To: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
thierry.reding@gmail.com, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 2/2] regulator: core: Check for DT every time we check full constraints
Date: Wed, 27 Nov 2013 16:53:54 +0000 [thread overview]
Message-ID: <20131127165354.GL14725@sirena.org.uk> (raw)
In-Reply-To: <1385569979.32005.2.camel@linaro1.home>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Wed, Nov 27, 2013 at 04:32:59PM +0000, Jon Medhurst (Tixy) wrote:
> Doesn't this now make this code in regulator_init_complete()
> redundant..?
> if (of_have_populated_dt())
> has_full_constraints = true;
Yes, it is a bit redundant now.
> Or is keeping this to avoid one less variable check a worthwhile
> optimisation?
I expect it can be removed, I just wanted to check that the function
wasn't horribly expensive for some silly reason before I actually went
and did that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-27 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 16:24 [PATCH 1/2] regulator: core: Replace checks of have_full_constraints with a function Mark Brown
2013-11-27 16:24 ` [PATCH 2/2] regulator: core: Check for DT every time we check full constraints Mark Brown
2013-11-27 16:32 ` Jon Medhurst (Tixy)
2013-11-27 16:53 ` Mark Brown [this message]
2013-11-27 16:55 ` Fabio Estevam
2013-11-29 10:56 ` [PATCH 1/2] regulator: core: Replace checks of have_full_constraints with a function Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127165354.GL14725@sirena.org.uk \
--to=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.