All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt.porter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties
Date: Wed, 27 Nov 2013 11:56:08 -0500	[thread overview]
Message-ID: <20131127165608.GC31091@beef> (raw)
In-Reply-To: <529475B2.9070202@ti.com>

On Tue, Nov 26, 2013 at 03:49:30PM +0530, Kishon Vijay Abraham I wrote:
> On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
> > dwc2/s3c-hsotg require a single clock to be specified and optionally
> > a generic phy. On the s3c-hsotg driver old style USB phy support is
> > present as a fallback so the generic phy properties are optional.
> > 
> > Signed-off-by: Matt Porter <matt.porter@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/staging/dwc2.txt | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt
> > index 1a1b7cf..b8b42b6 100644
> > --- a/Documentation/devicetree/bindings/staging/dwc2.txt
> > +++ b/Documentation/devicetree/bindings/staging/dwc2.txt
> > @@ -5,6 +5,12 @@ Required properties:
> >  - compatible : "snps,dwc2"
> >  - reg : Should contain 1 register range (address and length)
> >  - interrupts : Should contain 1 interrupt
> > +- clocks: clock provider specifier
> > +- clock-names: shall be "otg"
> > +- phys: phy provider specifier
> > +- phy-names: shall be "device"
> 
> lets mention in the Documentation too that the phy properties are optional.
> apart from that..

Good point, will do so.

> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> > +Refer to clk/clock-bindings.txt for generic clock consumer properties
> > +Refer to phy/phy-bindings.txt for generic phy consumer properties
> >  
> >  Example:
> >  
> > @@ -12,4 +18,8 @@ Example:
> >                  compatible = "ralink,rt3050-usb, snps,dwc2";
> >                  reg = <0x101c0000 40000>;
> >                  interrupts = <18>;
> > +		clocks = <&usb_otg_ahb_clk>;
> > +		clock-names = "otg";
> > +		phys = <&usbphy>;
> > +		phy-names = "device";
> >          };
> > 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <matt.porter@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Kumar Gala <galak@codeaurora.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Christian Daudt <bcm@fixthebug.org>,
	Paul Zimmerman <paulz@synopsys.com>,
	Tomasz Figa <t.figa@samsung.com>,
	Kamil Debski <k.debski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Linux USB List <linux-usb@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties
Date: Wed, 27 Nov 2013 11:56:08 -0500	[thread overview]
Message-ID: <20131127165608.GC31091@beef> (raw)
In-Reply-To: <529475B2.9070202@ti.com>

On Tue, Nov 26, 2013 at 03:49:30PM +0530, Kishon Vijay Abraham I wrote:
> On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
> > dwc2/s3c-hsotg require a single clock to be specified and optionally
> > a generic phy. On the s3c-hsotg driver old style USB phy support is
> > present as a fallback so the generic phy properties are optional.
> > 
> > Signed-off-by: Matt Porter <matt.porter@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/staging/dwc2.txt | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt
> > index 1a1b7cf..b8b42b6 100644
> > --- a/Documentation/devicetree/bindings/staging/dwc2.txt
> > +++ b/Documentation/devicetree/bindings/staging/dwc2.txt
> > @@ -5,6 +5,12 @@ Required properties:
> >  - compatible : "snps,dwc2"
> >  - reg : Should contain 1 register range (address and length)
> >  - interrupts : Should contain 1 interrupt
> > +- clocks: clock provider specifier
> > +- clock-names: shall be "otg"
> > +- phys: phy provider specifier
> > +- phy-names: shall be "device"
> 
> lets mention in the Documentation too that the phy properties are optional.
> apart from that..

Good point, will do so.

> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> > +Refer to clk/clock-bindings.txt for generic clock consumer properties
> > +Refer to phy/phy-bindings.txt for generic phy consumer properties
> >  
> >  Example:
> >  
> > @@ -12,4 +18,8 @@ Example:
> >                  compatible = "ralink,rt3050-usb, snps,dwc2";
> >                  reg = <0x101c0000 40000>;
> >                  interrupts = <18>;
> > +		clocks = <&usb_otg_ahb_clk>;
> > +		clock-names = "otg";
> > +		phys = <&usbphy>;
> > +		phy-names = "device";
> >          };
> > 
> 

  reply	other threads:[~2013-11-27 16:56 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 18:15 [PATCH v3 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-11-25 18:15 ` Matt Porter
2013-11-25 18:15 ` [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-11-25 18:15   ` Matt Porter
2013-11-26 10:16   ` Kishon Vijay Abraham I
2013-11-26 10:16     ` Kishon Vijay Abraham I
2013-11-26 10:16     ` Kishon Vijay Abraham I
2013-11-27 16:55     ` Matt Porter
2013-11-27 16:55       ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-26 10:19   ` Kishon Vijay Abraham I
2013-11-26 10:19     ` Kishon Vijay Abraham I
2013-11-26 10:19     ` Kishon Vijay Abraham I
2013-11-27 16:56     ` Matt Porter [this message]
2013-11-27 16:56       ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-11-25 18:16   ` [PATCH v3 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 " Matt Porter
2013-11-25 18:16 ` [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-26 10:23   ` Kishon Vijay Abraham I
2013-11-26 10:23     ` Kishon Vijay Abraham I
2013-11-26 10:23     ` Kishon Vijay Abraham I
2013-11-27 17:13     ` Matt Porter
2013-11-27 17:13       ` Matt Porter
2013-11-27 22:36       ` Matt Porter
2013-11-27 22:36         ` Matt Porter
2013-11-27 22:36         ` Matt Porter
2013-11-28  5:53         ` Kishon Vijay Abraham I
2013-11-28  5:53           ` Kishon Vijay Abraham I
2013-11-28  5:53           ` Kishon Vijay Abraham I
2013-11-28 16:41           ` Matt Porter
2013-11-28 16:41             ` Matt Porter
2013-11-28 16:41             ` Matt Porter
2013-11-28 17:02             ` Kamil Debski
2013-11-28 17:02               ` Kamil Debski
2013-11-28 17:02               ` Kamil Debski
2013-11-25 18:16 ` [PATCH v3 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-26 10:28   ` Kishon Vijay Abraham I
2013-11-26 10:28     ` Kishon Vijay Abraham I
2013-11-26 10:28     ` Kishon Vijay Abraham I
2013-11-27 17:16     ` Matt Porter
2013-11-27 17:16       ` Matt Porter
2013-11-27 17:16       ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-26 10:31   ` Kishon Vijay Abraham I
2013-11-26 10:31     ` Kishon Vijay Abraham I
2013-11-26 10:31     ` Kishon Vijay Abraham I
2013-11-27 17:19     ` Matt Porter
2013-11-27 17:19       ` Matt Porter
2013-11-27 17:19       ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-27  8:51   ` Kishon Vijay Abraham I
2013-11-27  8:51     ` Kishon Vijay Abraham I
2013-11-27  8:51     ` Kishon Vijay Abraham I
2013-11-27 17:21     ` Matt Porter
2013-11-27 17:21       ` Matt Porter
2013-11-27 17:21       ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-25 18:16   ` Matt Porter
2013-11-27  8:57   ` Kishon Vijay Abraham I
2013-11-27  8:57     ` Kishon Vijay Abraham I
2013-11-27  8:57     ` Kishon Vijay Abraham I
2013-11-27 17:24     ` Matt Porter
2013-11-27 17:24       ` Matt Porter
2013-11-27 17:24       ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127165608.GC31091@beef \
    --to=matt.porter@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.