Re: [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 14 Nov 2013 11:54:13 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> This series decouples readline.c from the QEMU monitor and then reuses it in
> qemu-io.  This adds history and command completion to the qemu-io interactive
> prompt.

I don't know what's the state of this series, but I reviewed the HMP
parts in detail, and took a glance at the qemu-io parts:

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> 
> Stefan Hajnoczi (5):
>   readline: decouple readline from the monitor
>   readline: move readline to a generic location
>   osdep: add qemu_set_tty_echo()
>   qemu-io: use readline.c
>   qemu-io: add command completion
> 
>  Makefile.objs              |   1 -
>  hmp.c                      |   6 +-
>  include/monitor/monitor.h  |   2 +-
>  include/monitor/readline.h |  56 -----
>  include/qemu-io.h          |   3 +
>  include/qemu/osdep.h       |   2 +
>  include/qemu/readline.h    |  62 ++++++
>  monitor.c                  |  41 +++-
>  qemu-io-cmds.c             |  15 ++
>  qemu-io.c                  | 109 +++++-----
>  readline.c                 | 493 --------------------------------------------
>  util/Makefile.objs         |   1 +
>  util/oslib-posix.c         |  18 ++
>  util/oslib-win32.c         |  19 ++
>  util/readline.c            | 495 +++++++++++++++++++++++++++++++++++++++++++++
>  15 files changed, 716 insertions(+), 607 deletions(-)
>  delete mode 100644 include/monitor/readline.h
>  create mode 100644 include/qemu/readline.h
>  delete mode 100644 readline.c
>  create mode 100644 util/readline.c
>