All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Zheng Liu <wenqing.lz@taobao.com>,
	Rich Johnston <rjohnston@sgi.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add a new test case to test i_size updated properly under dio
Date: Thu, 28 Nov 2013 11:34:16 +1100	[thread overview]
Message-ID: <20131128003416.GL10988@dastard> (raw)
In-Reply-To: <1385013394-20379-1-git-send-email-wenqing.lz@taobao.com>

On Thu, Nov 21, 2013 at 01:56:34PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> In this commit a new test case is added to test that i_size is updated
> properly under dio reads/writes.  We add a program in /src dir, which
> has a writer to issue some append dio writes.  Meanwhile it has a
> reader in this test do some dio reads.  As we expect, reader should read
> nothing or data with 'a'.  But it might read some data with '0'.
> 
> This program is used to simulate binary log operations of database
> application.  In these applications it implements an master/slave
> synchronziation for database.
> 
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Rich Johnston <rjohnston@sgi.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
>  src/Makefile          |    2 +-
>  src/diotest.c         |  166 +++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/generic/321     |   56 +++++++++++++++++
>  tests/generic/321.out |    1 +
>  tests/generic/group   |    1 +
>  5 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 src/diotest.c
>  create mode 100755 tests/generic/321
>  create mode 100644 tests/generic/321.out
> 
> diff --git a/src/Makefile b/src/Makefile
> index 84c8297..8c4f592 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -18,7 +18,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
>  	locktest unwritten_mmap bulkstat_unlink_test t_stripealign \
>  	bulkstat_unlink_test_modified t_dir_offset t_futimens t_immutable \
>  	stale_handle pwrite_mmap_blocked t_dir_offset2 seek_sanity_test \
> -	seek_copy_test t_readdir_1 t_readdir_2 fsync-tester nsexec
> +	seek_copy_test t_readdir_1 t_readdir_2 fsync-tester nsexec diotest

Fails to compile:

/tmp/cc54N2JC.o: In function `main':
/home/dave/src/xfstests-dev/src/diotest.c:120: undefined reference to `pthread_create'
/home/dave/src/xfstests-dev/src/diotest.c:135: undefined reference to `pthread_join'

It needs to be linked against libpthread, I think, so that needs to
be added to the LLDLIBS line, and the appropriate autoconf detection
macros added. You shoul dbe able to just copy the some
detection/infrastructure macros across from xfsprogs...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Rich Johnston <rjohnston@sgi.com>,
	Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] xfstests: add a new test case to test i_size updated properly under dio
Date: Thu, 28 Nov 2013 11:34:16 +1100	[thread overview]
Message-ID: <20131128003416.GL10988@dastard> (raw)
In-Reply-To: <1385013394-20379-1-git-send-email-wenqing.lz@taobao.com>

On Thu, Nov 21, 2013 at 01:56:34PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> In this commit a new test case is added to test that i_size is updated
> properly under dio reads/writes.  We add a program in /src dir, which
> has a writer to issue some append dio writes.  Meanwhile it has a
> reader in this test do some dio reads.  As we expect, reader should read
> nothing or data with 'a'.  But it might read some data with '0'.
> 
> This program is used to simulate binary log operations of database
> application.  In these applications it implements an master/slave
> synchronziation for database.
> 
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Rich Johnston <rjohnston@sgi.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
>  src/Makefile          |    2 +-
>  src/diotest.c         |  166 +++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/generic/321     |   56 +++++++++++++++++
>  tests/generic/321.out |    1 +
>  tests/generic/group   |    1 +
>  5 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 src/diotest.c
>  create mode 100755 tests/generic/321
>  create mode 100644 tests/generic/321.out
> 
> diff --git a/src/Makefile b/src/Makefile
> index 84c8297..8c4f592 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -18,7 +18,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
>  	locktest unwritten_mmap bulkstat_unlink_test t_stripealign \
>  	bulkstat_unlink_test_modified t_dir_offset t_futimens t_immutable \
>  	stale_handle pwrite_mmap_blocked t_dir_offset2 seek_sanity_test \
> -	seek_copy_test t_readdir_1 t_readdir_2 fsync-tester nsexec
> +	seek_copy_test t_readdir_1 t_readdir_2 fsync-tester nsexec diotest

Fails to compile:

/tmp/cc54N2JC.o: In function `main':
/home/dave/src/xfstests-dev/src/diotest.c:120: undefined reference to `pthread_create'
/home/dave/src/xfstests-dev/src/diotest.c:135: undefined reference to `pthread_join'

It needs to be linked against libpthread, I think, so that needs to
be added to the LLDLIBS line, and the appropriate autoconf detection
macros added. You shoul dbe able to just copy the some
detection/infrastructure macros across from xfsprogs...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2013-11-28  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  5:56 [PATCH] xfstests: add a new test case to test i_size updated properly under dio Zheng Liu
2013-11-28  0:34 ` Dave Chinner [this message]
2013-11-28  0:34   ` Dave Chinner
2013-11-28  2:23   ` Zheng Liu
2013-11-28  2:23     ` Zheng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131128003416.GL10988@dastard \
    --to=david@fromorbit.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rjohnston@sgi.com \
    --cc=wenqing.lz@taobao.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.