All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
Date: Thu, 28 Nov 2013 11:27:06 +0530	[thread overview]
Message-ID: <20131128055706.GM8834@intel.com> (raw)
In-Reply-To: <1385408365-8072-1-git-send-email-jason@lakedaemon.net>

+ Dan

On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> The following commit:
> 
>   54f8d501e842 dmaengine: remove DMA unmap from drivers
> 
> removed the last caller to mv_desc_get_dest_addr(), creating the
> warning:
> 
>   drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>   but not used [-Wunused-function]
> 
> Remove it.
> 
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Vinod Koul <vinod.koul@intel.com>

This should go thru Dan's tree

> ---
>  drivers/dma/mv_xor.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 7807f0ef4e20..23bcc9158cbc 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -54,12 +54,6 @@ static void mv_desc_init(struct mv_xor_desc_slot *desc, unsigned long flags)
>  	hw_desc->desc_command = (1 << 31);
>  }
>  
> -static u32 mv_desc_get_dest_addr(struct mv_xor_desc_slot *desc)
> -{
> -	struct mv_xor_desc *hw_desc = desc->hw_desc;
> -	return hw_desc->phy_dest_addr;
> -}
> -
>  static void mv_desc_set_byte_count(struct mv_xor_desc_slot *desc,
>  				   u32 byte_count)
>  {
> -- 
> 1.8.4.4
> 

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Jason Cooper <jason@lakedaemon.net>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
Date: Thu, 28 Nov 2013 11:27:06 +0530	[thread overview]
Message-ID: <20131128055706.GM8834@intel.com> (raw)
In-Reply-To: <1385408365-8072-1-git-send-email-jason@lakedaemon.net>

+ Dan

On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> The following commit:
> 
>   54f8d501e842 dmaengine: remove DMA unmap from drivers
> 
> removed the last caller to mv_desc_get_dest_addr(), creating the
> warning:
> 
>   drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>   but not used [-Wunused-function]
> 
> Remove it.
> 
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Vinod Koul <vinod.koul@intel.com>

This should go thru Dan's tree

> ---
>  drivers/dma/mv_xor.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 7807f0ef4e20..23bcc9158cbc 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -54,12 +54,6 @@ static void mv_desc_init(struct mv_xor_desc_slot *desc, unsigned long flags)
>  	hw_desc->desc_command = (1 << 31);
>  }
>  
> -static u32 mv_desc_get_dest_addr(struct mv_xor_desc_slot *desc)
> -{
> -	struct mv_xor_desc *hw_desc = desc->hw_desc;
> -	return hw_desc->phy_dest_addr;
> -}
> -
>  static void mv_desc_set_byte_count(struct mv_xor_desc_slot *desc,
>  				   u32 byte_count)
>  {
> -- 
> 1.8.4.4
> 

-- 

  parent reply	other threads:[~2013-11-28  5:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 19:39 [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr() Jason Cooper
2013-11-25 19:39 ` Jason Cooper
2013-11-25 19:46 ` Jason Cooper
2013-11-25 19:46   ` Jason Cooper
2013-11-27 19:45   ` Olof Johansson
2013-11-27 19:45     ` Olof Johansson
2013-11-27 23:58     ` Jason Cooper
2013-11-27 23:58       ` Jason Cooper
2013-11-28  5:57 ` Vinod Koul [this message]
2013-11-28  5:57   ` Vinod Koul
2013-12-09 23:50   ` Russell King - ARM Linux
2013-12-09 23:50     ` Russell King - ARM Linux
2013-12-10 10:13     ` Vinod Koul
2013-12-10 10:13       ` Vinod Koul
2013-12-10 11:14       ` Russell King - ARM Linux
2013-12-10 11:14         ` Russell King - ARM Linux
2013-12-11  9:10         ` Dan Williams
2013-12-11  9:10           ` Dan Williams
2013-12-13  7:00           ` Dan Williams
2013-12-13  7:00             ` Dan Williams
2013-12-18 15:40             ` Vinod Koul
2013-12-18 15:40               ` Vinod Koul
2013-12-18 16:55               ` Dan Williams
2013-12-18 16:55                 ` Dan Williams
2013-12-18 16:33                 ` Vinod Koul
2013-12-18 16:33                   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131128055706.GM8834@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.