From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@kernel.org, azurit@pobox.sk, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [merged] mm-memcg-handle-non-error-oom-situations-more-gracefully.patch removed from -mm tree
Date: Thu, 28 Nov 2013 10:12:55 +0100 [thread overview]
Message-ID: <20131128091255.GD2761@dhcp22.suse.cz> (raw)
In-Reply-To: <20131127233353.GH3556@cmpxchg.org>
On Wed 27-11-13 18:33:53, Johannes Weiner wrote:
[...]
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 13b9d0f..5f9e467 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2675,7 +2675,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm,
> goto bypass;
>
> if (unlikely(task_in_memcg_oom(current)))
> - goto bypass;
> + goto nomem;
>
> /*
> * We always charge the cgroup the mm_struct belongs to.
Yes, I think we really want this. Plan to send a patch? The first charge
failure due to OOM shouldn't be papered over by a later attempt if we
didn't get through mem_cgroup_oom_synchronize yet.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@kernel.org, azurit@pobox.sk, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [merged] mm-memcg-handle-non-error-oom-situations-more-gracefully.patch removed from -mm tree
Date: Thu, 28 Nov 2013 10:12:55 +0100 [thread overview]
Message-ID: <20131128091255.GD2761@dhcp22.suse.cz> (raw)
In-Reply-To: <20131127233353.GH3556@cmpxchg.org>
On Wed 27-11-13 18:33:53, Johannes Weiner wrote:
[...]
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 13b9d0f..5f9e467 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2675,7 +2675,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm,
> goto bypass;
>
> if (unlikely(task_in_memcg_oom(current)))
> - goto bypass;
> + goto nomem;
>
> /*
> * We always charge the cgroup the mm_struct belongs to.
Yes, I think we really want this. Plan to send a patch? The first charge
failure due to OOM shouldn't be papered over by a later attempt if we
didn't get through mem_cgroup_oom_synchronize yet.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2013-11-28 9:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 18:13 [merged] mm-memcg-handle-non-error-oom-situations-more-gracefully.patch removed from -mm tree akpm
2013-11-27 23:08 ` David Rientjes
2013-11-27 23:08 ` David Rientjes
2013-11-27 23:33 ` Johannes Weiner
2013-11-27 23:33 ` Johannes Weiner
2013-11-28 0:56 ` David Rientjes
2013-11-28 0:56 ` David Rientjes
2013-11-28 2:18 ` Johannes Weiner
2013-11-28 2:18 ` Johannes Weiner
2013-11-28 2:38 ` David Rientjes
2013-11-28 2:38 ` David Rientjes
2013-11-28 3:13 ` Johannes Weiner
2013-11-28 3:13 ` Johannes Weiner
2013-11-28 3:20 ` David Rientjes
2013-11-28 3:20 ` David Rientjes
2013-11-28 3:52 ` Johannes Weiner
2013-11-28 3:52 ` Johannes Weiner
2013-11-30 0:00 ` David Rientjes
2013-11-30 0:00 ` David Rientjes
2013-11-30 0:51 ` Greg KH
2013-11-30 0:51 ` Greg KH
2013-11-30 10:25 ` David Rientjes
2013-11-30 10:25 ` David Rientjes
2013-11-30 3:35 ` Johannes Weiner
2013-11-30 3:35 ` Johannes Weiner
2013-11-30 10:32 ` David Rientjes
2013-11-30 10:32 ` David Rientjes
2013-11-30 15:55 ` Johannes Weiner
2013-11-30 15:55 ` Johannes Weiner
2013-11-30 22:12 ` David Rientjes
2013-11-30 22:12 ` David Rientjes
2013-11-28 10:02 ` Michal Hocko
2013-11-28 10:02 ` Michal Hocko
2013-11-30 0:05 ` David Rientjes
2013-11-30 0:05 ` David Rientjes
2013-12-02 13:12 ` Michal Hocko
2013-12-02 13:12 ` Michal Hocko
2013-12-02 22:51 ` David Rientjes
2013-12-02 22:51 ` David Rientjes
2013-11-28 9:12 ` Michal Hocko [this message]
2013-11-28 9:12 ` Michal Hocko
2013-11-30 3:37 ` Johannes Weiner
2013-11-30 3:37 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128091255.GD2761@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=azurit@pobox.sk \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.